Upgrade of DetailedList core and iOS #246
Conversation
There was a problem hiding this comment.
This looks great! I've got 2 comments.
The first I've flagged inline (about data sources). You should be able to use the Table data source stuff pretty much as-is - although you might want to look at expanding that interface so that the data source can confirm if deletion/refresh is allowed (i.e., it's the data source that allows/disallows refresh/delete. A simple list data source, by default, can't be refreshed, but can have elements deleted; but you could turn off deletion if you wanted to)
The second comment is about visualisation. This widget was originally written for a quick-and-dirty demo, so I cheated a bit with the way the visualization worked, and just encoded a simple text label for each entry. Ideally, we'd want to be able to have different display styles - including icons, title and subtitle, arrow indicators that suggest selection will cause navigation elsewhere, tag lozenges...
In terms of this specific PR, we probably only have to handle the data source issue; but if you've got any ideas about a visualization interface, that would be handy too.
| return self._data | ||
|
|
||
| @data.setter | ||
| def data(self, data_list): | ||
| def data(self, data_list: list): |
There was a problem hiding this comment.
This should be a data source, not just a list. (c.f., the way tree/table handles data). Ideally, we want to allow end users to have dynamic sources of data, and have them displayed as a detailed list.
Ocupe
force-pushed
the
upgrade_detailedlist
branch
from
c3d04b1 to
56651aa
Compare
* added on_select functionality * refresh is now only possible when a on_refresh handler was set. * added documentation. Signed-off-by: Jonas Schell <[email protected]>
* actions are remove, insert, clear * this is needed for the iOS backend Signed-off-by: Jonas Schell <[email protected]>
Signed-off-by: Jonas Schell <[email protected]>
Signed-off-by: Jonas Schell <[email protected]>
Ocupe
force-pushed
the
upgrade_detailedlist
branch
from
97bc681 to
3665e4e
Compare
Signed-off-by: Jonas Schell <[email protected]>
|
@freakboy3742 DetailedList uses now ListDataSource. I also included a example app. The I still have to come up with a good way for styling of rows, but I think this is going to be another PR. Other than that I'm ready for a final review. |
Signed-off-by: Jonas Schell [email protected]