Fix scrolling to bottom of sidebars. #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is due to a JavaScript "feature" that handles the height of the sidebars, clashing with the changes we made to compensate for that feature so we could reclaim screen-space for the rest of the docs.
Unfortunately, after several hours of fighting with it, this is the best solution I can work out. There will be a gap at the bottom of the sidebar if you scroll to the bottom of the page and the sidebar. However, it doesn't hide anything at the top, and you can always scroll back up. I spoke with Russ about it, and he can live with it.
@mhsmith If you consider this suitable, please merge it at your convenience.
Fixes #148.
PR Checklist: