Implemented a DimsImagemagickThreadLimit module configuration directive #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier to troubleshoot in case of wrong redirects, or plain origin server errors.
We use(d) these operations for My Opera and Discover.
Sadly, I don't remember what was the problem anymore. Refers to our internal commit 39fc429258dcc76554d015a286105289b18487b0.
Useful when converting PNG pictures to JPEG and at the same time changing the default black color. Maybe we could sample the picture colors and decide a suitable background color too.
It's necessary to apply the background filter early
in the URL chain. If you define a URL like:
/resize/240x>/background/red/
then the picture will result with a red background
but it will be the original size. I'm not familiar enough
with ImageMagick to understand why at this point, so
just put your background filter at the beginning.
/background/grey/resize/240x>/
This will work.
Conflicts: src/mod_dims.c src/mod_dims.h src/mod_dims_ops.c
In ImageMagick 6.8.5, there's no ParseMagickOption(). That function was renamed to ParseCommandOption(). http://trac.imagemagick.org/changeset/4281/ImageMagick/trunk/magick/image.c
Should be the same as doing MAGICK_THREAD_LIMIT, but done at module initialisation time rather than at request time.
Author
|
It's working :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to try this in production today.