Fix missing keep_in_artist option in ftintitle plugin (introduced in #5356) #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newly introduced option to keep the feat. artist in the artist field when importing with the ftintitle plugin was not passed in one function.
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
3 tasks
JOJ0
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug introduced in #5356.
The new
keep_in_artistoption for the ftintitle plugin was introduced in #5356.However, it was not passed to the
importedfunction. (See @chrishoage's comment in #5356).This is fixed with this PR.
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)