Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platformdirs #5412

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Add support for platformdirs #5412

merged 4 commits into from
Sep 20, 2024

Conversation

bal-e
Copy link
Member

@bal-e bal-e commented Sep 8, 2024

Description

Fixes #5168 and follows on #5333.

Thanks to @snejus for suggesting platformdirs instead of trying to roll my own XDG user-dirs.dirs parser. It's well-tested, supports more platforms, and may come in handy for other features in the future.

To Do

  • Documentation
  • Changelog
  • Tests

Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Added a couple of nitpicky comments and suggestion regarding bytestring_path

pyproject.toml Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
beets/library.py Outdated Show resolved Hide resolved
beets/library.py Outdated Show resolved Hide resolved
beets/library.py Outdated Show resolved Hide resolved
@bal-e bal-e requested a review from snejus September 12, 2024 12:26
beets/library.py Outdated Show resolved Hide resolved
Copy link
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for your patience!

@bal-e
Copy link
Member Author

bal-e commented Sep 20, 2024

Thanks!

@bal-e bal-e merged commit cd360b6 into beetbox:master Sep 20, 2024
12 checks passed
@bal-e bal-e deleted the platformdirs branch September 20, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beets should respect $XDG_MUSIC_DIR
2 participants