Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and do not install reflink on Windows for tests #5407

Merged
merged 6 commits into from
Sep 8, 2024

Conversation

snejus
Copy link
Member

@snejus snejus commented Sep 4, 2024

See my comment under #5406 for context

The build on win32 is failing to install reflink because it's only supported until Python 3.7.

I will address this in a separate PR and rebase this one accordingly once the fix is merged.

Note: this issue popped up now because I added a new requests-mock dependency which invalidated cached dependencies.

@snejus snejus self-assigned this Sep 4, 2024
@snejus snejus requested a review from bal-e September 4, 2024 15:57
Copy link

github-actions bot commented Sep 4, 2024

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@snejus snejus changed the title Update dependencies and do not install reflink for tests Update dependencies and do not install reflink on Windows for tests Sep 4, 2024
@snejus snejus force-pushed the update-dependencies branch 3 times, most recently from 57edba8 to e767906 Compare September 4, 2024 18:03
test/test_files.py Show resolved Hide resolved
@snejus snejus requested a review from bal-e September 7, 2024 09:14
test/test_files.py Show resolved Hide resolved
@bal-e
Copy link
Member

bal-e commented Sep 8, 2024

LGTM, I think?

@snejus snejus merged commit 54b2435 into master Sep 8, 2024
12 checks passed
@snejus snejus deleted the update-dependencies branch September 8, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants