-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lrclib lyrics #5406
Open
snejus
wants to merge
26
commits into
master
Choose a base branch
from
fix-lrclib-lyrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix lrclib lyrics #5406
+847
−3,390
Commits on Oct 1, 2024
-
Fix fetching lyrics from lrclib
Adjust the base URL to perform a '/search' instead of attempting to '/get' specific lyrics where we're unlikely to find lyrics for the specific combination of album, artist, track names and the duration (see https://lrclib.net/docs). Since we receive an array of matching lyrics candidates, rank them by their duration similarity to the item's duration, and whether they contain synced lyrics.
Configuration menu - View commit details
-
Copy full SHA for 5b9bfa2 - Browse repository at this point
Copy the full SHA 5b9bfa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eff52f - Browse repository at this point
Copy the full SHA 8eff52fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b51ce93 - Browse repository at this point
Copy the full SHA b51ce93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02df047 - Browse repository at this point
Copy the full SHA 02df047View commit details -
Configuration menu - View commit details
-
Copy full SHA for aefb00d - Browse repository at this point
Copy the full SHA aefb00dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a0d78a - Browse repository at this point
Copy the full SHA 3a0d78aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c662a92 - Browse repository at this point
Copy the full SHA c662a92View commit details -
lyrics: isolate test configuration
Create 'helpers.ConfigMixin' which sets up testing configuration. This is helpful for tests (e.g. test_lyrics.py) that only need the configuration and do not require temp dir. (#5102) Refactor lyrics tests to fix the issue global beets config issue. Additionally, add 'integration_test' mark that can be used to mark tests that should only run once a week.
Configuration menu - View commit details
-
Copy full SHA for 595c2b2 - Browse repository at this point
Copy the full SHA 595c2b2View commit details -
Centralize requests setup with requests.Session
Improve requests performance with requests.Session which uses connection pooling for repeated requests to the same host. Additionally, this centralizes request configuration, making sure that we use the same timeout and provide beets user agent for all requests.
Configuration menu - View commit details
-
Copy full SHA for 9d3fbc1 - Browse repository at this point
Copy the full SHA 9d3fbc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a3b9cb - Browse repository at this point
Copy the full SHA 0a3b9cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e15625d - Browse repository at this point
Copy the full SHA e15625dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f5fa21 - Browse repository at this point
Copy the full SHA 2f5fa21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60e6cbe - Browse repository at this point
Copy the full SHA 60e6cbeView commit details -
Do not handle empty lyrics html case
Due to request error handling this logic will only run for successful requests, so we can safely assume the html to be a string.
Configuration menu - View commit details
-
Copy full SHA for 30b7ef7 - Browse repository at this point
Copy the full SHA 30b7ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51ae847 - Browse repository at this point
Copy the full SHA 51ae847View commit details -
Configuration menu - View commit details
-
Copy full SHA for e221f06 - Browse repository at this point
Copy the full SHA e221f06View commit details -
Use a single slug implementation
Tidy up 'Google.is_page_candidate' method and remove 'Google.sluggify' method which was a duplicate of 'slug'. Since 'GeniusFetchTest' only tested whether the artist name is cleaned up (the rest of the functionality is patched), remove it and move its test cases to the 'test_slug' test.
Configuration menu - View commit details
-
Copy full SHA for ec00c75 - Browse repository at this point
Copy the full SHA ec00c75View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc155c9 - Browse repository at this point
Copy the full SHA bc155c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba48ca - Browse repository at this point
Copy the full SHA 4ba48caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d8b2c8 - Browse repository at this point
Copy the full SHA 3d8b2c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ead06e - Browse repository at this point
Copy the full SHA 2ead06eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d6071 - Browse repository at this point
Copy the full SHA 58d6071View commit details -
Configuration menu - View commit details
-
Copy full SHA for aba3776 - Browse repository at this point
Copy the full SHA aba3776View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0ee0a1 - Browse repository at this point
Copy the full SHA f0ee0a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9399f66 - Browse repository at this point
Copy the full SHA 9399f66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16cfd91 - Browse repository at this point
Copy the full SHA 16cfd91View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.