Repository navigation
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
The scripting module documents
scripts = "none"andscripts = "custom"as configuration alternatives to--scripts. However,ScriptsRequiredcurrently accepts only the capitalized Rust variant names through serde. A config containing the documented lowercase spelling fails TOML deserialization;Config::readaborts on that error.Change
Accept
none,default, andcustomas serde aliases. PreserveNone,Default, andCustom, reject unknown/empty strings, and leaveScanOrderunchanged.Tests cover each lowercase spelling, the legacy spellings and invalid inputs. An additional test writes ephemeral config fixtures and calls the real public
Config::read(Some(path))for all three lowercase modes, without changingHOMEor running a scan or script.Verification
Against exact base
937903340aa6266abb26e93ea3241026b3fd8150, native Ubuntu24.04/stable Rust qualification:--deny warnings,cargo fmt --check, and required workspace/all-features/private-item docs pass.Owned qualification run checked out public upstream source and verified candidate tree
47cd6cf506009555fe13c98082bd468ca0c8a93a. This is independent qualification, not an upstream CI result or full platform matrix. Compilation and native tests ran offline in an empty network namespace as an unprivileged user. No scans, DNS requests, or scripts were executed.Prepared with AI assistance; source and test evidence were independently reviewed before submission.