Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Content-type from request in ApiProxyTrait #87

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

didoda
Copy link
Member

@didoda didoda commented Aug 29, 2023

This resolves #49

Header Content-type is read from request headers, if available, in ApiProxyTrait.

@didoda didoda added enhancement New feature or request release:patch labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (6131a1a) 92.17% compared to head (8e37aa6) 92.22%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     92.17%   92.22%   +0.05%     
- Complexity      238      240       +2     
============================================
  Files            26       26              
  Lines           741      746       +5     
============================================
+ Hits            683      688       +5     
  Misses           58       58              
Files Changed Coverage Δ
src/Controller/ApiProxyTrait.php 99.16% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didoda didoda marked this pull request as ready for review August 29, 2023 13:39
@didoda didoda marked this pull request as draft August 29, 2023 13:58
@didoda didoda changed the title Options for get,patch,post,delete methods of ApiProxyTrait Header Content-type from request in ApiProxyTrait Aug 29, 2023
@didoda didoda marked this pull request as ready for review August 29, 2023 14:08
@didoda didoda marked this pull request as draft August 30, 2023 06:27
@didoda didoda marked this pull request as ready for review August 30, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers in ApiProxy trait
1 participant