Implement reporter options #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
+ Coverage 96.96% 97.08% +0.11%
==========================================
Files 2 2
Lines 99 103 +4
==========================================
+ Hits 96 100 +4
Misses 3 3
Continue to review full report at Codecov.
|
josevalim
approved these changes
Dec 23, 2019
|
❤️ 💚 💙 💛 💜 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the Summary metric, the need for reporter options is now needed to provide a mechanism for users to define options for which summary statistics to calculate and rates where appropriate. Prometheus, for instance, requires the time-window for the metric to be set by the user for Summaries. This PR is necessary to support the Summary type in Prometheus Core - beam-telemetry/telemetry_metrics_prometheus_core#11.
Closes #33