Additional support for caching from s3 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleviminzi
commented
Apr 25, 2025
Makefile
Outdated
Comment on lines
40
to
41
| cd hack; kubectl apply -f deployment.yaml; kubectl apply -f service.yaml; cd .. |
There was a problem hiding this comment.
still need this stuff for local dev (+ svc.yaml below)
This was referenced Apr 25, 2025
luke-lombardi
requested changes
May 1, 2025
| FUSE = 2; | ||
| CDN = 3; | ||
| } | ||
| message StoreContentFromSourceRequest { |
pkg/s3_client.go
Outdated
| @@ -42,7 +43,12 @@ func NewS3Client(ctx context.Context, sourceConfig S3SourceConfig) (*S3Client, e | |||
| cfg.BaseEndpoint = aws.String(sourceConfig.EndpointURL) | |||
There was a problem hiding this comment.
do we still need this line if we're doing it later on line 46?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.