Support latest distro args in pxemenu

[cbouchar]

For latest distros, the variables 'method' and 'repos' are not supported in beaker pxemenu. Replace with 'inst.repos' instead. The latest distros are
RHEL9, CentOSStream9, FedoraRawhide, FedoraELN, and Fedora34 and up.

[JohnVillalovos]

How about:

    if osmajor.lower() in ('fedoraeln', 'fedorarawhide'):
        return True

[mdujava]

just a side-note. I usually use list as a right hand side of such expression. Quick search shows that for small number of values, (), [] have similar performance (even assemble into same code) except using {} which is a little bit faster as it uses frozenset:

$ python3 -m timeit -s 'x = "test"' 'x in ("one", "two")'
10000000 loops, best of 5: 24.2 nsec per loop
$ python3 -m timeit -s 'x = "test"' 'x in ["one", "two"]'
10000000 loops, best of 5: 24.6 nsec per loop
$ python3 -m timeit -s 'x = "test"' 'x in {"one", "two"}'
20000000 loops, best of 5: 15.3 nsec per loop

[JohnVillalovos]

Hehe. Interesting. I'll keep that in mind for large amounts of iterations and try to remember to just use it by default. It doesn't make a meaningful difference here. But in some situations it could be a valuable optimization!

[JohnVillalovos]

If mark it as a regular-expression string using r" Then should not need the noqa portion

    split_str = re.split(r"(RedHatEnterpriseLinux|Fedora|CentOSStream)(\d+)", osmajor)

But how about this instead?

      result = re.search(r"([a-zA-Z]+)(\d+)", osmajor)
      if result is None:
          return False
      distro = result.groups()[0]
      version = int(result.groups()[1])

      if distro in ('RedHatEnterpriseLinux', 'CentOSStream') and version > 8:
          return True
      if distro == 'Fedora' and version > 33:
          return True
      return False

[jchristi]

agree with above suggestion, the conditional logic can be made more readable.

[mdujava]

Also named groups can be used r"(?P<distro>RedHatEnterpriseLinux|Fedora|CentOSStream)(?P<version>\d+)"

[JohnVillalovos]

Also named groups can be used r"(?P<distro>RedHatEnterpriseLinux|Fedora|CentOSStream)(?P<version>\d+)"

I considered that. But when I tried it, the code seemed more complicated if using either result.groupdict() or result.group("distro"). But could add the named groups as like a comment about what each portion of the regex is. Though I don't think it is necessary.

[jchristi]

LGTM, just one comment from John that should be addressed.

[jchristi]

agree with above suggestion, the conditional logic can be made more readable.

[cbouchar]

Yes I'm working on it but need to change downstream first where I know full Unit Test suite runs which takes hours.