Fix changed URL for VSTSDK #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please someone else check that this works for them, but it sure works for me!
|
Linked to: #49 |
bdejong
approved these changes
Jun 26, 2023
|
Thanks for merging @bdejong but did you note the issue I commented on in the PR above where this now doesn't build? Did you manage to fix that? This PR wasn't yet complete. |
|
It wasn't building before either... I prefer to merge and then fix the things that need fixing. For the Steinberg headers etc I think I will just pull them into the repository rather than trying to download them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is incomplete and needs more work, but it's definitely heading in the right direction.
Please someone else check that this works for them, but it sure works for me!
Except something isn't quite right, as after this I get a build error:
[cmake] Cannot find source file: [cmake] [cmake] ..../smartelectronix/Steinberg/public.sdk/source/vst2.x/audioeffect.cppWhich looks like it's due to the new folder:
vstsdk2sitting abovepublic.sdkso the build scripts need to be changed to reflect this....I tried manually editing
smartelecronix/Common/common.cmakewith the new paths, but it didn't help.Even doing that doesn't fix it since aeffect.h doesn't exist in the new SDK. @bdejong any ideas?