Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gleam v0.32 #15

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Update for Gleam v0.32 #15

merged 1 commit into from
Nov 6, 2023

Conversation

lpil
Copy link
Contributor

@lpil lpil commented Nov 6, 2023

I've also made the tmp files be written to a git ignored tmp rather than into the src tree as a crash half way through the tests left me with various test files to delete before I could run the tests again. I hope that's ok!

@bcpeinhardt
Copy link
Owner

bcpeinhardt commented Nov 6, 2023

You're positively fabulous for taking the time to do this, sorry I've been consumed with the new job. I plan to rejoin the gleam world asap 😃

@bcpeinhardt
Copy link
Owner

bcpeinhardt commented Nov 6, 2023

Because of the way main (in test) is set up, the tests will sometimes fail to run (because delete("/tmp") will return an Error if there's no /tmp to begin with). Would you mind changing that line to ignore the delete result and then assert tmp does not exist, or use delete_all which will ignore an Enoent error?
Note: That api is a bit confusing. Maybe there should be like expect_and_delete and delete_if_found or something. Naming things is hard.

@lpil
Copy link
Contributor Author

lpil commented Nov 6, 2023

Oh yes! Thank you

I've also made the tmp files be written to a git ignored `tmp` rather
than into the src tree as a crash half way through the tests left me
with various test files to delete before I could run the tests again. I
hope that's ok!
@bcpeinhardt bcpeinhardt merged commit 166748f into bcpeinhardt:main Nov 6, 2023
1 check passed
@bcpeinhardt
Copy link
Owner

Published as 0.2.0 (just felt right with the whole new gleam version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants