feat: add hook emergency uninstall #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
requested review from
filmakarov,
ankurdubey521 and
VGabriel45
|
@kopy-kat do you have implementation of the hook that will be used for resource locking? |
|
no, we havent started prototyping the resource lock hook yet. We do have an audited hook multiplexer tho: https://github.com/rhinestonewtf/core-modules/blob/main/src/HookMultiPlexer/HookMultiPlexer.sol |
VGabriel45
approved these changes
Aug 27, 2024
livingrockrises
approved these changes
Sep 4, 2024
|
ready to merge post spearbit review |
|
can just merge now and will inform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please refer to description and comments on
#150
https://medium.com/rhinestonewtf/omnichain-smart-accounts-with-erc-7579-modules-170b21cc5b50