Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the hardhat deployment script #148

Closed
wants to merge 1 commit into from

Conversation

VGabriel45
Copy link
Collaborator

No description provided.

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L12

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.08%. Comparing base (7166cae) to head (b87b512).
Report is 21 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #148      +/-   ##
==========================================
- Coverage   72.36%   72.08%   -0.28%     
==========================================
  Files          13       13              
  Lines         673      677       +4     
  Branches      147      125      -22     
==========================================
+ Hits          487      488       +1     
- Misses        186      189       +3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327e1e4...b87b512. Read the comment docs.

@VGabriel45
Copy link
Collaborator Author

Closing this, didn't notice @joepegler pushed a fix for this.

@VGabriel45 VGabriel45 closed this Aug 21, 2024
@livingrockrises livingrockrises deleted the fix/fix_hardhat_deployment_script branch October 14, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant