Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooking upgradeToAndCall #141

Merged

Conversation

livingrockrises
Copy link
Contributor

No description provided.

@livingrockrises livingrockrises merged commit fe885d6 into remediations/cantina-spearbit Aug 16, 2024
5 checks passed
@livingrockrises livingrockrises deleted the feat/hooking-upgradeToAndCall branch August 16, 2024 13:24
Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/RegistryBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L12

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

hooking upgradeToAndCall

Generated at commit: 80d3913bc04d10a682d8a193d31437c910a2ffc7

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
1
0
7
24
32

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (626a3a2) to head (80d3913).
Report is 25 commits behind head on remediations/cantina-spearbit.

Files Patch % Lines
contracts/Nexus.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           remediations/cantina-spearbit     #141      +/-   ##
=================================================================
+ Coverage                          71.86%   72.19%   +0.32%     
=================================================================
  Files                                 13       13              
  Lines                                686      694       +8     
  Branches                             126      150      +24     
=================================================================
+ Hits                                 493      501       +8     
  Misses                               193      193              
Files Coverage Δ
contracts/Nexus.sol 63.06% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da18b3d...80d3913. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant