Remediations/cyfrin

[livingrockrises]

No description provided.

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

• constable-states (2 results) (Optimization)

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-0
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L12

• ID-1
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

[github-actions]

Changes to gas cost

Generated at commit: 59ffaa9a05637c9fc7a73cec219d22b390beef24, compared to commit: 1c0fd0b9c8a98924ef377f801c838aaab986b429

🧾 Summary (5% most significant diffs)

Contract	Method	Avg (+/-)	%
Bootstrap	initNexusScoped	+677 ❌	+0.83%
Nexus	initializeAccount	+677 ❌	+0.52%

---

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
Bootstrap	2,429,946 (-22,590)	initNexusScoped	62,207 (+677)	+1.10%	82,042 (+677)	+0.83%	82,107 (+677)	+0.83%	82,107 (+677)	+0.83%	309 (0)
Nexus	5,401,892 (+432)	initializeAccount	110,748 (+677)	+0.62%	130,583 (+677)	+0.52%	130,648 (+677)	+0.52%	130,648 (+677)	+0.52%	309 (0)
NexusAccountFactory	816,559 (+20,395)	createAccount	212,343 (+660)	+0.31%	229,964 (+660)	+0.29%	232,483 (+660)	+0.28%	232,483 (+660)	+0.28%	8 (0)
BiconomyMetaFactory	717,254 (+216)

[openzeppelin-code]

Remediations/cyfrin

Generated at commit: 7c014644c174756ee328dd2bfa6097df1ead69df

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	0 1 0 6 25 32

---

For more details view the full report in OpenZeppelin Code Inspector

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.58%. Comparing base (2f9a401) to head (7c01464).
Report is 19 commits behind head on dev.

Files	Patch %	Lines
contracts/factory/NexusAccountFactory.sol	0.00%	2 Missing ⚠️
contracts/factory/RegistryFactory.sol	0.00%	2 Missing ⚠️
contracts/Nexus.sol	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2f9a401) and HEAD (7c01464). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (2f9a401)	HEAD (7c01464)
foundry	1	0

Additional details and impacted files

@@             Coverage Diff             @@
##              dev     #137       +/-   ##
===========================================
- Coverage   87.29%   68.58%   -18.72%     
===========================================
  Files          13       12        -1     
  Lines         559      503       -56     
  Branches      122      112       -10     
===========================================
- Hits          488      345      -143     
- Misses         69      158       +89     
+ Partials        2        0        -2     

Files	Coverage Δ
contracts/base/ModuleManager.sol	71.32% <ø> (-22.47%)	⬇️
contracts/factory/BiconomyMetaFactory.sol	100.00% <100.00%> (+6.66%)	⬆️
contracts/factory/K1ValidatorFactory.sol	100.00% <ø> (+9.09%)	⬆️
contracts/Nexus.sol	68.33% <0.00%> (-18.39%)	⬇️
contracts/factory/NexusAccountFactory.sol	88.88% <0.00%> (ø)
contracts/factory/RegistryFactory.sol	0.00% <0.00%> (-73.34%)	⬇️

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0fd0b...7c01464. Read the comment docs.