Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix size limit by removing unneeded function #136

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

VGabriel45
Copy link

No description provided.

Copy link

github-actions bot commented Aug 14, 2024

Changes to gas cost

Generated at commit: e7f044cf60845023f1907971a543e69dbbbe9a02, compared to commit: 1c0fd0b9c8a98924ef377f801c838aaab986b429

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %
Nexus execute
executeFromExecutor
-22 ✅
-22 ✅
-0.04%
-0.11%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
Nexus 5,353,180 (-48,280) execute
executeFromExecutor
6,190 (-22)
14,507 (-22)
-0.35%
-0.15%
48,963 (-22)
19,781 (-22)
-0.04%
-0.11%
37,890 (-22)
19,588 (-22)
-0.06%
-0.11%
142,968 (-22)
25,443 (-22)
-0.02%
-0.09%
76 (0)
4 (0)

Copy link

openzeppelin-code bot commented Aug 14, 2024

fix: fix size limit by removing unneeded function

Generated at commit: 7166caed5ab89c788a33320f6394e077ed191e66

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
1
0
6
24
31

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.36%. Comparing base (2f9a401) to head (7166cae).
Report is 25 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #136       +/-   ##
===========================================
- Coverage   87.29%   72.36%   -14.94%     
===========================================
  Files          13       13               
  Lines         559      673      +114     
  Branches      122      147       +25     
===========================================
- Hits          488      487        -1     
- Misses         69      186      +117     
+ Partials        2        0        -2     
Files Coverage Δ
contracts/Nexus.sol 63.15% <ø> (-23.57%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0fd0b...7166cae. Read the comment docs.

Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. but I think you should do this once everything else is in dev

@VGabriel45
Copy link
Author

approved. but I think you should do this once everything else is in dev

Will wait for all remediations then pull dev and merge this

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L12

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

@livingrockrises livingrockrises merged commit ba67d11 into dev Aug 19, 2024
9 of 10 checks passed
@livingrockrises livingrockrises deleted the fix/size_limit branch August 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants