Fix Finding #19: Ensure Validator Module Type Check in Enable Mode #126
Conversation
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use
constable-statesImpact: Optimization
|
Changes to gas cost
🧾 Summary (5% most significant diffs)
Full diff report 👇
|
Fix Finding #19: Ensure Validator Module Type Check in Enable Mode
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/finding-18-withdraw-deposit-memory #126 +/- ##
==========================================================================
+ Coverage 72.60% 72.68% +0.08%
==========================================================================
Files 13 13
Lines 657 659 +2
Branches 123 149 +26
==========================================================================
+ Hits 477 479 +2
Misses 180 180
Continue to review full report in Codecov by Sentry.
|
Aboudjem
requested review from
filmakarov and
livingrockrises
and removed request for
filmakarov
| @@ -107,8 +107,10 @@ contract Nexus is INexus, BaseAccount, ExecutionHelper, ModuleManager, UUPSUpgra | |||
| } else { | |||
| PackedUserOperation memory userOp = op; | |||
| userOp.signature = _enableMode(validator, op.signature); | |||
| // Ensure the module being enabled is a validator | |||
| if (!_isValidatorInstalled(validator)) return VALIDATION_FAILED; | |||
There was a problem hiding this comment.
We should modify the wiki then https://github.com/bcnmy/nexus/wiki/Modules#module-enable-mode here it states that ANY MODULE can be installed using enableMode @Aboudjem
There was a problem hiding this comment.
right ! @filmakarov @livingrockrises can you confirm it is the intended behavior?
There was a problem hiding this comment.
Fil's PR states this in finality
#112
There was a problem hiding this comment.
so should be closed?
Aboudjem
merged commit 4d0c119
into
fix/finding-18-withdraw-deposit-memory
validateUserOp.