Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/finding #18 Prevent Memory Overwrite in withdrawDepositTo Function #125

Merged
merged 23 commits into from
Aug 19, 2024
Merged

Fix/finding #18 Prevent Memory Overwrite in withdrawDepositTo Function #125

merged 23 commits into from
Aug 19, 2024

Commits on Aug 1, 2024

  1. refactor: fix withdrawDepositTo function in BaseAccount.sol

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    748efe1 View commit details
    Browse the repository at this point in the history

  2. refactor: Enable module being enabled to be a validator in Nexus.sol

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    75e8fb5 View commit details
    Browse the repository at this point in the history

  3. lint fix

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f23b948 View commit details
    Browse the repository at this point in the history

  4. refactor: Update ModuleManager to validate module type before install… 

    …ation
    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    00e4a43 View commit details
    Browse the repository at this point in the history

  5. refactor: Add tests for enable mode and negative test

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4d0c119 View commit details
    Browse the repository at this point in the history

  6. refactor: Improve error handling in ExecutionHelper contract

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    03e8e92 View commit details
    Browse the repository at this point in the history

  7. refactor: Add TryDelegateCallUnsuccessful event to EventsAndErrors.sol

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6c350ea View commit details
    Browse the repository at this point in the history

  8. refactor: Add TryExecuteUnsuccessful and TryDelegateCallUnsuccessful … 

    …tests to TestAccountExecution_TryExecuteSingle.t.sol
    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7a63137 View commit details
    Browse the repository at this point in the history

  9. refactor: update tree test

    @Aboudjem
    Aboudjem committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9c2537d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. chore: fix script location (#130)

    @joepegler
    joepegler authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1c0fd0b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. feat: replace index with calldata in event

    @GabiDev45
    GabiDev45 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d12b063 View commit details
    Browse the repository at this point in the history

  2. refactor: Improve withdrawDepositTo function in BaseAccount.sol

    @Aboudjem
    Aboudjem committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    96d9261 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. refactor: Merge branch 'feat/events_replace_index_with_calldata' of h… 

    …ttps://github.com/bcnmy/nexus into fix/finding-21-emit-events
    @GabiDev45
    GabiDev45 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e1cc884 View commit details
    Browse the repository at this point in the history

  2. refactor: emit events with calldata fix

    @GabiDev45
    GabiDev45 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1e83820 View commit details
    Browse the repository at this point in the history

  3. refactor: added missing calldata in events

    @GabiDev45
    GabiDev45 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4c05522 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #127 from bcnmy/fix/finding-21-emit-events 

    Fix/finding #21 - Emit Events for Failed Try Execution in `execute`
    @livingrockrises
    livingrockrises authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b0f009a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix/finding-2-salt-determinism' into fix/finding-18-wit… 

    …hdraw-deposit-memory
    @Aboudjem
    Aboudjem authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    534ba42 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. fix based on fiding 18 - withdrawDepositTo function in BaseAccount.sol

    @Aboudjem
    Aboudjem committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7a200ee View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. refactor: Restore overwritten memory pointer in BaseAccount.sol

    @Aboudjem
    Aboudjem committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ec1d3b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Merge branch 'remediations/cantina-spearbit' into fix/finding-18-with… 

    …draw-deposit-memory
    @Aboudjem
    Aboudjem committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    795f731 View commit details
    Browse the repository at this point in the history

  2. chore: Update emit statement in TestAccountExecution_TryExecuteSingle… 

    ….t.sol
    @Aboudjem
    Aboudjem committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    e036430 View commit details
    Browse the repository at this point in the history

  3. fix enablemode tests

    @Aboudjem
    Aboudjem committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    79956d4 View commit details
    Browse the repository at this point in the history

  4. chore: Update TryDelegateCallUnsuccessful event parameters in EventsA… 

    …ndErrors.sol
    @Aboudjem
    Aboudjem committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    902c284 View commit details
    Browse the repository at this point in the history