Feat/erc 7579 interfaces #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, module, and module configuration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 6 +4
Lines 11 42 +31
Branches 3 0 -3
=========================================
+ Hits 11 42 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
filmakarov
approved these changes
Feb 20, 2024
| * @param mode The encoded execution mode of the transaction. | ||
| * @param executionCalldata The encoded execution call data. | ||
| */ | ||
| function execute(bytes32 mode, bytes calldata executionCalldata) external payable { |
There was a problem hiding this comment.
this is like standard executor? execute and executeBatch which comes by default. I don't see executeBatch
There was a problem hiding this comment.
This is part of the ERC7579, mode can be batch and then the calldata will be executed accordingly
|
|
||
| import { PackedUserOperation } from "account-abstraction/contracts/interfaces/PackedUserOperation.sol"; | ||
|
|
||
| contract Validator { |
There was a problem hiding this comment.
aren't these interfaces or abstract contracts?
There was a problem hiding this comment.
It's just importing the PackedUserOperation struct
There was a problem hiding this comment.
I mean contract Validator
| // SPDX-License-Identifier: MIT | ||
| pragma solidity >=0.8.24; | ||
|
|
||
| import { EntryPoint } from "account-abstraction/contracts/core/EntryPoint.sol"; |
There was a problem hiding this comment.
how are we importing? from sub-module? and branch=develop
There was a problem hiding this comment.
Yes
"account-abstraction": "github:eth-infinitism/account-abstraction#develop",
I've added this as devDep
and remapped it
account-abstraction/=node_modules/account-abstraction/ for forge usage
| import { ModuleConfig } from "./Account/ModuleConfig.sol"; | ||
| import { Validator } from "./Account/Validator.sol"; | ||
|
|
||
| contract SmartAccount is AccountConfig, Execution, ModuleConfig, Validator { |
There was a problem hiding this comment.
I agree we can combine Execution and Validator into account and just use interfaces to be kept in ISmartAccount. if that's not strict requirement by ERC
There was a problem hiding this comment.
I separated them because Validator is part of ERC4337, and Execution is part of ERC7579
| * @param encodedMode The encoded mode. | ||
| * @return True if the account supports the mode, false otherwise. | ||
| */ | ||
| function supportsAccountMode(bytes32 encodedMode) external view returns (bool); |
There was a problem hiding this comment.
would suggest renaming this to something which makes more sense as per natspecs
There was a problem hiding this comment.
this part of the erc7579, do you have any naming in mind?
There was a problem hiding this comment.
accountSupportsMode ??
* 👷 Add Slither analysis workflow * ♻️ Update Slither workflow to include Foundry installation*** * Add permissions and update Slither configuration * Update Slither workflow to ensure tool availability * Update Slither workflow * Add Slither workflow to run static analysis * 💚 add yarn.lock * ✨ Update Slither workflow to include Node.js setup and SARIF report generation * Remove SARIF file upload step in slither.yml * Update Slither configuration in workflow * 🚧 Update Slither workflow to include Foundry installation and contract building * Remove target directory for analysis in slither.yml workflow * 🚑 Update Slither workflow to include SARIF file upload * Add token to SARIF file upload * Add comment.js and update slither.yml workflow * Update node version in slither.yml * Update Slither workflow to fail on medium severity issues * Add target directory for Slither analysis * Update slither.yml with filter paths for mock contracts * Update slither-args in slither.yml * Fix slither-args path in GitHub workflow * Update slither configuration to exclude node_modules directory * Update slither-args in slither.yml workflow * Update Slither version to 0.10.0 * Update slither.yml to fail on no severity issues * Add check for pull request event in comment.js
* Update GitHub Actions workflow to trigger on pull requests * Update Slither workflow permissions and arguments * Refactor CI workflow and remove redundant coverage and slither workflows * Update Node.js and Foundry versions * Add Foundry to PATH * Update CI workflow to install lcov and make other improvements * Add cache for Foundry Toolchain * Update CI workflow configuration * Refactor GitHub Actions workflow*** * Update CI workflow to cache node_modules and Foundry toolchain * Update CI workflow and add linting, unit tests, coverage, and static analysis * Update cache keys and add Foundry toolchain * Add Foundry cache key generation and ensure Foundry directory exists * Update CI workflow and cache actions*** * Update CI workflow and dependencies * Update CI workflow to install Foundry and generate coverage report * Add lcov installation step and update Codecov upload for Foundry and Hardhat coverage reports * Refactor CI workflow and add Slither analysis * Update CI Workflow to include linting, unit tests, coverage, and slither analysis
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use
locked-etherImpact: Medium
shadowing-localImpact: Low
assemblyImpact: Informational
solc-versionImpact: Informational
redundant-statementsImpact: Informational
|
livingrockrises
approved these changes
Feb 21, 2024
Aboudjem
added a commit
that referenced
this pull request
Mar 8, 2024
* 🎨 init repo * 👷 update ci * 🎨 update badges * Feat/add husky (#4) * Add husky for Git hooks * 🚧 add branch naming check * ✅Add Git hooks for branch name validation * 💚 Update pre-push script to remove unnecessary line * Add branch name validation checks for dev and main branches * 🚧 Update branch naming check workflow * 👷 Add PR Automation Workflow (#6) * Release/0.1.0 (#9) * 🔖 Update package.json version to 0.1.0 * 💚 Fix versioning check in automation workflow * ⚡️ Fix CI/CD workflows and update changelog * 💚 Sync release branch to dev and create automated PR * Update versioning check in automation workflow * 💚 Update automation_workflow.yml to check for changes in package.json and CHANGELOG.md * Refactor workflow to check for updated files * Refactor code to improve performance and readability * Add LICENSE file to GitHub Actions workflow * 💚 Update automation workflow to check for changed files * Update automation_workflow.yml to check for changes in package.json and CHANGELOG.md files * Add checks for package.json, CHANGELOG.md, and LICENSE files * Refactor verification logic in automation workflow * Update automation_workflow.yml to verify changes in CHANGELOG.md file * 💚 Add automation workflow for creating PRs to dev and main branches * Update GitHub Actions versions * 💚 Update automation_workflow.yml to use dynamic branch names * Update GitHub token in automation_workflow.yml * Refactor automation workflow to remove unnecessary steps * Feat/erc 7579 interfaces (#12) * 🙈 Add cache_forge to .gitignore * Add .husky to .gitignore * 🎨 Update tab width to 4 spaces in .prettierrc * 🚧 Disable no-inline-assembly rule in .solhint.json * ⚡️ Add account-abstraction dependency and update husky hooks * 🔥 Remove Git hooks for branch name validation * 🔧 Update tsconfig.json to disable strict mode * 🎨 Update Solidity version and remappings, delete unused contracts and tests * 🙈 Add .vscode/settings.json to .gitignore * 🔥 Delete unused contracts and tests * ✨ Add utility functions for conversion and formatting * ✨ Add buildUserOp function to utils.ts * ✨ Add git hook to check branch names * ✨ Add SmartAccount contract * ✨ Add AccountConfig contract implementation * ✨ Add Execution contract for account execution * ✨ Add ModuleConfig contract for managing modules * ✨ Add Storage contract for isolated storage access * ✨ Add Validator contract for user operation validation * ⚡️ Add ERC-7579 interfaces for smart account configuration, execution, module, and module configuration * ✨ Add IStorage interface for ERC20 account storage * 🚀 Add deployment of SmartAccount contract * 🚧 Update import statement and variable name in Deploy script * ⚡️ Add Entrypoint 0.7.0 * ⚡️ Add Imports.sol for consolidated imports * ✅ Add SmartAccount test file * 👷 Remove unnecessary branch from PR Automation Workflow * ✏️ Update storage location for SmartAccount in contracts * Feat/slither (#14) * 👷 Add Slither analysis workflow * ♻️ Update Slither workflow to include Foundry installation*** * Add permissions and update Slither configuration * Update Slither workflow to ensure tool availability * Update Slither workflow * Add Slither workflow to run static analysis * 💚 add yarn.lock * ✨ Update Slither workflow to include Node.js setup and SARIF report generation * Remove SARIF file upload step in slither.yml * Update Slither configuration in workflow * 🚧 Update Slither workflow to include Foundry installation and contract building * Remove target directory for analysis in slither.yml workflow * 🚑 Update Slither workflow to include SARIF file upload * Add token to SARIF file upload * Add comment.js and update slither.yml workflow * Update node version in slither.yml * Update Slither workflow to fail on medium severity issues * Add target directory for Slither analysis * Update slither.yml with filter paths for mock contracts * Update slither-args in slither.yml * Fix slither-args path in GitHub workflow * Update slither configuration to exclude node_modules directory * Update slither-args in slither.yml workflow * Update Slither version to 0.10.0 * Update slither.yml to fail on no severity issues * Add check for pull request event in comment.js * Update GitHub Actions workflow to trigger on pull requests (#15) * Update GitHub Actions workflow to trigger on pull requests * Update Slither workflow permissions and arguments * Refactor CI workflow and remove redundant coverage and slither workflows * Update Node.js and Foundry versions * Add Foundry to PATH * Update CI workflow to install lcov and make other improvements * Add cache for Foundry Toolchain * Update CI workflow configuration * Refactor GitHub Actions workflow*** * Update CI workflow to cache node_modules and Foundry toolchain * Update CI workflow and add linting, unit tests, coverage, and static analysis * Update cache keys and add Foundry toolchain * Add Foundry cache key generation and ensure Foundry directory exists * Update CI workflow and cache actions*** * Update CI workflow and dependencies * Update CI workflow to install Foundry and generate coverage report * Add lcov installation step and update Codecov upload for Foundry and Hardhat coverage reports * Refactor CI workflow and add Slither analysis * Update CI Workflow to include linting, unit tests, coverage, and slither analysis * Refactor CI workflow and update Slither analysis * [WIP] Refactor and Start implementing methods (#17) * 🙈 Add cache_forge to .gitignore * Add .husky to .gitignore * 🎨 Update tab width to 4 spaces in .prettierrc * 🚧 Disable no-inline-assembly rule in .solhint.json * ⚡️ Add account-abstraction dependency and update husky hooks * 🔥 Remove Git hooks for branch name validation * 🔧 Update tsconfig.json to disable strict mode * 🎨 Update Solidity version and remappings, delete unused contracts and tests * 🙈 Add .vscode/settings.json to .gitignore * 🔥 Delete unused contracts and tests * ✨ Add utility functions for conversion and formatting * ✨ Add buildUserOp function to utils.ts * ✨ Add git hook to check branch names * ✨ Add SmartAccount contract * ✨ Add AccountConfig contract implementation * ✨ Add Execution contract for account execution * ✨ Add ModuleConfig contract for managing modules * ✨ Add Storage contract for isolated storage access * ✨ Add Validator contract for user operation validation * ⚡️ Add ERC-7579 interfaces for smart account configuration, execution, module, and module configuration * ✨ Add IStorage interface for ERC20 account storage * 🚀 Add deployment of SmartAccount contract * 🚧 Update import statement and variable name in Deploy script * ⚡️ Add Entrypoint 0.7.0 * ⚡️ Add Imports.sol for consolidated imports * ✅ Add SmartAccount test file * 👷 Remove unnecessary branch from PR Automation Workflow * ✏️ Update storage location for SmartAccount in contracts * Feat/slither (#14) * 👷 Add Slither analysis workflow * ♻️ Update Slither workflow to include Foundry installation*** * Add permissions and update Slither configuration * Update Slither workflow to ensure tool availability * Update Slither workflow * Add Slither workflow to run static analysis * 💚 add yarn.lock * ✨ Update Slither workflow to include Node.js setup and SARIF report generation * Remove SARIF file upload step in slither.yml * Update Slither configuration in workflow * 🚧 Update Slither workflow to include Foundry installation and contract building * Remove target directory for analysis in slither.yml workflow * 🚑 Update Slither workflow to include SARIF file upload * Add token to SARIF file upload * Add comment.js and update slither.yml workflow * Update node version in slither.yml * Update Slither workflow to fail on medium severity issues * Add target directory for Slither analysis * Update slither.yml with filter paths for mock contracts * Update slither-args in slither.yml * Fix slither-args path in GitHub workflow * Update slither configuration to exclude node_modules directory * Update slither-args in slither.yml workflow * Update Slither version to 0.10.0 * Update slither.yml to fail on no severity issues * Add check for pull request event in comment.js * Update GitHub Actions workflow to trigger on pull requests (#15) * Update GitHub Actions workflow to trigger on pull requests * Update Slither workflow permissions and arguments * Refactor CI workflow and remove redundant coverage and slither workflows * Update Node.js and Foundry versions * Add Foundry to PATH * Update CI workflow to install lcov and make other improvements * Add cache for Foundry Toolchain * Update CI workflow configuration * Refactor GitHub Actions workflow*** * Update CI workflow to cache node_modules and Foundry toolchain * Update CI workflow and add linting, unit tests, coverage, and static analysis * Update cache keys and add Foundry toolchain * Add Foundry cache key generation and ensure Foundry directory exists * Update CI workflow and cache actions*** * Update CI workflow and dependencies * Update CI workflow to install Foundry and generate coverage report * Add lcov installation step and update Codecov upload for Foundry and Hardhat coverage reports * Refactor CI workflow and add Slither analysis * Update CI Workflow to include linting, unit tests, coverage, and slither analysis * lint comment.js module * prettier on branch name check and add comments * Refactor CI workflow and update Slither analysis * Refactor comment.js and ci.yml to improve Slither analysis report generation * Add Module contract implementation * Fix returnData initialization bug in Execution.sol and import IModule in Module.sol * Refactor getEmoji function to use text instead of impact level * Update TYPE_ID constant to uint256 * Refactor comment.js to add URL shortening and emoji processing * Update constant declaration in Module.sol * Refactor comment.js to improve readability and add emojis * Refactor comment.js to improve URL shortening and emoji handling * refactor, change acc id * 🎨 further refactor. add module types * ⚙️ validateUserOp implementation * ✅ add execute via EP test * Add remappings and solady module * 📦 Add new dependencies and update existing ones * 🔨 Update package.json with new check-branch-name script * Add 'deployments' to .gitignore * Add hardhat-deploy package * Refactor comment.js * Refactor buildUserOp function and add new utility functions * Add UserOperation and PackedUserOperation interfaces * 📦 Update dependencies in yarn.lock * Update husky hooks in package.json * 🔥 Remove unused contract files * 🐛 revert remappings in remappings.txt due to issue with hh * Remove duplicated account-abstraction dep * Update import paths for PackedUserOperation * Remove unused contracts and imports * ♻️ Update AccountConfig implementation ID * 🙈 Add .solcover.js configuration file * 🙈 add solcover * 🔥 remove utils * 🔥 remove account.test.ts * 🎨 improve code with interface * ✨ add encoding utils function * ✨ add helpers for operation * 🔥 remove unused module * 🚀 utils for deployment * ✨ add Counter test contract * ✅ add mockvalidator for test purpose * 🎨 simplify Execution funcs for quick test * ✨ add onInstall hook on moduleManager * 🔥 remove empty useless contract * 🚀 add basic AccountFactory * 🎨 add interface for AccountFactory * ✅ add deployment tests * ✅ add configuration tests * ✅ add module management tests * ✅ add acc execution tests * 🚨 lint fix * chore: forge init * forge install: forge-std v1.7.6 * chore: forge init * Delete CounterTest contract and related tests * Remove submodule lib/forge-std * 🔧 Update remappings in remappings.txt * 📦 Add ds-test dependency * 📦 Add ds-test dependency * ✨ Add computeAccountAddress function to AccountFactory * Add test function to ignore coverage of ModuleTypeLib.sol * Add test function to MockValidator to ignore coverage * Remove forge-std subproject * Update import path for Script.sol * ✨ Add Structs.sol with ModuleType enum * 🚚 Update import statement in Storage.sol * 🚚 Update module interface in AccountFactory * Remove deprecated interfaces * Add IStorage interface definition * Update imports in Imports.sol * ✨ Add Helpers.sol with utility functions * Refactor code to improve performance and readability * Refactor BicoTestBase and import Helpers and console2.sol * Add Forge-std Test import and refactor newWallet function * 🚨 Lint fix * Delete unnecessary files * 🔥 Remove unused function isInitialized() * ⚡️ Refactor comment posting logic to delete existing Slither comments * lint fix (Remove empty line in IModule.sol) * 🐛 fix missing var on comment.js * Add uniqueSlitherHeader to markdownComment * Remove test workflow * refactor * proposed naming convention changes * rename to supportsExecutionMode * lint refactor * refactor as per discussion / PR * fix linter with unused import * 🎨 lint --------- Co-authored-by: aboudjem <[email protected]> Co-authored-by: Filipp Makarov <[email protected]> Co-authored-by: livingrockrises <[email protected]> * Update version to 0.2.0 in CHANGELOG.md and package.json --------- Co-authored-by: filmakarov <[email protected]> Co-authored-by: Filipp Makarov <[email protected]> Co-authored-by: livingrockrises <[email protected]>
Aboudjem
added a commit
that referenced
this pull request
Jun 4, 2024
* Release/0.1.0 (#10) * 🎨 init repo * 👷 update ci * 🎨 update badges * Feat/add husky (#4) * Add husky for Git hooks * 🚧 add branch naming check * ✅Add Git hooks for branch name validation * 💚 Update pre-push script to remove unnecessary line * Add branch name validation checks for dev and main branches * 🚧 Update branch naming check workflow * 👷 Add PR Automation Workflow (#6) * 🔖 Update package.json version to 0.1.0 * 💚 Fix versioning check in automation workflow * ⚡️ Fix CI/CD workflows and update changelog * 💚 Sync release branch to dev and create automated PR * Update versioning check in automation workflow * 💚 Update automation_workflow.yml to check for changes in package.json and CHANGELOG.md * Refactor workflow to check for updated files * Refactor code to improve performance and readability * Add LICENSE file to GitHub Actions workflow * 💚 Update automation workflow to check for changed files * Update automation_workflow.yml to check for changes in package.json and CHANGELOG.md files * Add checks for package.json, CHANGELOG.md, and LICENSE files * Refactor verification logic in automation workflow * Update automation_workflow.yml to verify changes in CHANGELOG.md file * 💚 Add automation workflow for creating PRs to dev and main branches * Update GitHub Actions versions * 💚 Update automation_workflow.yml to use dynamic branch names * Update GitHub token in automation_workflow.yml * Refactor automation workflow to remove unnecessary steps * Release/0.2.0 (#22) * 🎨 init repo * 👷 update ci * 🎨 update badges * Feat/add husky (#4) * Add husky for Git hooks * 🚧 add branch naming check * ✅Add Git hooks for branch name validation * 💚 Update pre-push script to remove unnecessary line * Add branch name validation checks for dev and main branches * 🚧 Update branch naming check workflow * 👷 Add PR Automation Workflow (#6) * Release/0.1.0 (#9) * 🔖 Update package.json version to 0.1.0 * 💚 Fix versioning check in automation workflow * ⚡️ Fix CI/CD workflows and update changelog * 💚 Sync release branch to dev and create automated PR * Update versioning check in automation workflow * 💚 Update automation_workflow.yml to check for changes in package.json and CHANGELOG.md * Refactor workflow to check for updated files * Refactor code to improve performance and readability * Add LICENSE file to GitHub Actions workflow * 💚 Update automation workflow to check for changed files * Update automation_workflow.yml to check for changes in package.json and CHANGELOG.md files * Add checks for package.json, CHANGELOG.md, and LICENSE files * Refactor verification logic in automation workflow * Update automation_workflow.yml to verify changes in CHANGELOG.md file * 💚 Add automation workflow for creating PRs to dev and main branches * Update GitHub Actions versions * 💚 Update automation_workflow.yml to use dynamic branch names * Update GitHub token in automation_workflow.yml * Refactor automation workflow to remove unnecessary steps * Feat/erc 7579 interfaces (#12) * 🙈 Add cache_forge to .gitignore * Add .husky to .gitignore * 🎨 Update tab width to 4 spaces in .prettierrc * 🚧 Disable no-inline-assembly rule in .solhint.json * ⚡️ Add account-abstraction dependency and update husky hooks * 🔥 Remove Git hooks for branch name validation * 🔧 Update tsconfig.json to disable strict mode * 🎨 Update Solidity version and remappings, delete unused contracts and tests * 🙈 Add .vscode/settings.json to .gitignore * 🔥 Delete unused contracts and tests * ✨ Add utility functions for conversion and formatting * ✨ Add buildUserOp function to utils.ts * ✨ Add git hook to check branch names * ✨ Add SmartAccount contract * ✨ Add AccountConfig contract implementation * ✨ Add Execution contract for account execution * ✨ Add ModuleConfig contract for managing modules * ✨ Add Storage contract for isolated storage access * ✨ Add Validator contract for user operation validation * ⚡️ Add ERC-7579 interfaces for smart account configuration, execution, module, and module configuration * ✨ Add IStorage interface for ERC20 account storage * 🚀 Add deployment of SmartAccount contract * 🚧 Update import statement and variable name in Deploy script * ⚡️ Add Entrypoint 0.7.0 * ⚡️ Add Imports.sol for consolidated imports * ✅ Add SmartAccount test file * 👷 Remove unnecessary branch from PR Automation Workflow * ✏️ Update storage location for SmartAccount in contracts * Feat/slither (#14) * 👷 Add Slither analysis workflow * ♻️ Update Slither workflow to include Foundry installation*** * Add permissions and update Slither configuration * Update Slither workflow to ensure tool availability * Update Slither workflow * Add Slither workflow to run static analysis * 💚 add yarn.lock * ✨ Update Slither workflow to include Node.js setup and SARIF report generation * Remove SARIF file upload step in slither.yml * Update Slither configuration in workflow * 🚧 Update Slither workflow to include Foundry installation and contract building * Remove target directory for analysis in slither.yml workflow * 🚑 Update Slither workflow to include SARIF file upload * Add token to SARIF file upload * Add comment.js and update slither.yml workflow * Update node version in slither.yml * Update Slither workflow to fail on medium severity issues * Add target directory for Slither analysis * Update slither.yml with filter paths for mock contracts * Update slither-args in slither.yml * Fix slither-args path in GitHub workflow * Update slither configuration to exclude node_modules directory * Update slither-args in slither.yml workflow * Update Slither version to 0.10.0 * Update slither.yml to fail on no severity issues * Add check for pull request event in comment.js * Update GitHub Actions workflow to trigger on pull requests (#15) * Update GitHub Actions workflow to trigger on pull requests * Update Slither workflow permissions and arguments * Refactor CI workflow and remove redundant coverage and slither workflows * Update Node.js and Foundry versions * Add Foundry to PATH * Update CI workflow to install lcov and make other improvements * Add cache for Foundry Toolchain * Update CI workflow configuration * Refactor GitHub Actions workflow*** * Update CI workflow to cache node_modules and Foundry toolchain * Update CI workflow and add linting, unit tests, coverage, and static analysis * Update cache keys and add Foundry toolchain * Add Foundry cache key generation and ensure Foundry directory exists * Update CI workflow and cache actions*** * Update CI workflow and dependencies * Update CI workflow to install Foundry and generate coverage report * Add lcov installation step and update Codecov upload for Foundry and Hardhat coverage reports * Refactor CI workflow and add Slither analysis * Update CI Workflow to include linting, unit tests, coverage, and slither analysis * Refactor CI workflow and update Slither analysis * [WIP] Refactor and Start implementing methods (#17) * 🙈 Add cache_forge to .gitignore * Add .husky to .gitignore * 🎨 Update tab width to 4 spaces in .prettierrc * 🚧 Disable no-inline-assembly rule in .solhint.json * ⚡️ Add account-abstraction dependency and update husky hooks * 🔥 Remove Git hooks for branch name validation * 🔧 Update tsconfig.json to disable strict mode * 🎨 Update Solidity version and remappings, delete unused contracts and tests * 🙈 Add .vscode/settings.json to .gitignore * 🔥 Delete unused contracts and tests * ✨ Add utility functions for conversion and formatting * ✨ Add buildUserOp function to utils.ts * ✨ Add git hook to check branch names * ✨ Add SmartAccount contract * ✨ Add AccountConfig contract implementation * ✨ Add Execution contract for account execution * ✨ Add ModuleConfig contract for managing modules * ✨ Add Storage contract for isolated storage access * ✨ Add Validator contract for user operation validation * ⚡️ Add ERC-7579 interfaces for smart account configuration, execution, module, and module configuration * ✨ Add IStorage interface for ERC20 account storage * 🚀 Add deployment of SmartAccount contract * 🚧 Update import statement and variable name in Deploy script * ⚡️ Add Entrypoint 0.7.0 * ⚡️ Add Imports.sol for consolidated imports * ✅ Add SmartAccount test file * 👷 Remove unnecessary branch from PR Automation Workflow * ✏️ Update storage location for SmartAccount in contracts * Feat/slither (#14) * 👷 Add Slither analysis workflow * ♻️ Update Slither workflow to include Foundry installation*** * Add permissions and update Slither configuration * Update Slither workflow to ensure tool availability * Update Slither workflow * Add Slither workflow to run static analysis * 💚 add yarn.lock * ✨ Update Slither workflow to include Node.js setup and SARIF report generation * Remove SARIF file upload step in slither.yml * Update Slither configuration in workflow * 🚧 Update Slither workflow to include Foundry installation and contract building * Remove target directory for analysis in slither.yml workflow * 🚑 Update Slither workflow to include SARIF file upload * Add token to SARIF file upload * Add comment.js and update slither.yml workflow * Update node version in slither.yml * Update Slither workflow to fail on medium severity issues * Add target directory for Slither analysis * Update slither.yml with filter paths for mock contracts * Update slither-args in slither.yml * Fix slither-args path in GitHub workflow * Update slither configuration to exclude node_modules directory * Update slither-args in slither.yml workflow * Update Slither version to 0.10.0 * Update slither.yml to fail on no severity issues * Add check for pull request event in comment.js * Update GitHub Actions workflow to trigger on pull requests (#15) * Update GitHub Actions workflow to trigger on pull requests * Update Slither workflow permissions and arguments * Refactor CI workflow and remove redundant coverage and slither workflows * Update Node.js and Foundry versions * Add Foundry to PATH * Update CI workflow to install lcov and make other improvements * Add cache for Foundry Toolchain * Update CI workflow configuration * Refactor GitHub Actions workflow*** * Update CI workflow to cache node_modules and Foundry toolchain * Update CI workflow and add linting, unit tests, coverage, and static analysis * Update cache keys and add Foundry toolchain * Add Foundry cache key generation and ensure Foundry directory exists * Update CI workflow and cache actions*** * Update CI workflow and dependencies * Update CI workflow to install Foundry and generate coverage report * Add lcov installation step and update Codecov upload for Foundry and Hardhat coverage reports * Refactor CI workflow and add Slither analysis * Update CI Workflow to include linting, unit tests, coverage, and slither analysis * lint comment.js module * prettier on branch name check and add comments * Refactor CI workflow and update Slither analysis * Refactor comment.js and ci.yml to improve Slither analysis report generation * Add Module contract implementation * Fix returnData initialization bug in Execution.sol and import IModule in Module.sol * Refactor getEmoji function to use text instead of impact level * Update TYPE_ID constant to uint256 * Refactor comment.js to add URL shortening and emoji processing * Update constant declaration in Module.sol * Refactor comment.js to improve readability and add emojis * Refactor comment.js to improve URL shortening and emoji handling * refactor, change acc id * 🎨 further refactor. add module types * ⚙️ validateUserOp implementation * ✅ add execute via EP test * Add remappings and solady module * 📦 Add new dependencies and update existing ones * 🔨 Update package.json with new check-branch-name script * Add 'deployments' to .gitignore * Add hardhat-deploy package * Refactor comment.js * Refactor buildUserOp function and add new utility functions * Add UserOperation and PackedUserOperation interfaces * 📦 Update dependencies in yarn.lock * Update husky hooks in package.json * 🔥 Remove unused contract files * 🐛 revert remappings in remappings.txt due to issue with hh * Remove duplicated account-abstraction dep * Update import paths for PackedUserOperation * Remove unused contracts and imports * ♻️ Update AccountConfig implementation ID * 🙈 Add .solcover.js configuration file * 🙈 add solcover * 🔥 remove utils * 🔥 remove account.test.ts * 🎨 improve code with interface * ✨ add encoding utils function * ✨ add helpers for operation * 🔥 remove unused module * 🚀 utils for deployment * ✨ add Counter test contract * ✅ add mockvalidator for test purpose * 🎨 simplify Execution funcs for quick test * ✨ add onInstall hook on moduleManager * 🔥 remove empty useless contract * 🚀 add basic AccountFactory * 🎨 add interface for AccountFactory * ✅ add deployment tests * ✅ add configuration tests * ✅ add module management tests * ✅ add acc execution tests * 🚨 lint fix * chore: forge init * forge install: forge-std v1.7.6 * chore: forge init * Delete CounterTest contract and related tests * Remove submodule lib/forge-std * 🔧 Update remappings in remappings.txt * 📦 Add ds-test dependency * 📦 Add ds-test dependency * ✨ Add computeAccountAddress function to AccountFactory * Add test function to ignore coverage of ModuleTypeLib.sol * Add test function to MockValidator to ignore coverage * Remove forge-std subproject * Update import path for Script.sol * ✨ Add Structs.sol with ModuleType enum * 🚚 Update import statement in Storage.sol * 🚚 Update module interface in AccountFactory * Remove deprecated interfaces * Add IStorage interface definition * Update imports in Imports.sol * ✨ Add Helpers.sol with utility functions * Refactor code to improve performance and readability * Refactor BicoTestBase and import Helpers and console2.sol * Add Forge-std Test import and refactor newWallet function * 🚨 Lint fix * Delete unnecessary files * 🔥 Remove unused function isInitialized() * ⚡️ Refactor comment posting logic to delete existing Slither comments * lint fix (Remove empty line in IModule.sol) * 🐛 fix missing var on comment.js * Add uniqueSlitherHeader to markdownComment * Remove test workflow * refactor * proposed naming convention changes * rename to supportsExecutionMode * lint refactor * refactor as per discussion / PR * fix linter with unused import * 🎨 lint --------- Co-authored-by: aboudjem <[email protected]> Co-authored-by: Filipp Makarov <[email protected]> Co-authored-by: livingrockrises <[email protected]> * Update version to 0.2.0 in CHANGELOG.md and package.json --------- Co-authored-by: filmakarov <[email protected]> Co-authored-by: Filipp Makarov <[email protected]> Co-authored-by: livingrockrises <[email protected]> * update versions nexus to 1.0.0-beta * lint fix * fix conflicts * remove Husky hooks and gas report generation + lint fix + clean + badge update --------- Co-authored-by: filmakarov <[email protected]> Co-authored-by: Filipp Makarov <[email protected]> Co-authored-by: livingrockrises <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
PackedUserOpsto make it easier for our tests..gitignoreupdates to keep our repo clean of unnecessary files..solhint.jsonand.prettierrcfor better linting and formattingImports.solfor import for testing.I made important changes to ensure a solid foundation for our project. I focused on good practices and setting up everything we need to start developing effectively. These updates are just the beginning and meant to provide a good start