-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔒 H-03 - Enforce Registry Calls Before Module Setup to Comply with EIP-7484 #115
Conversation
Changes to gas cost
🧾 Summary (5% most significant diffs)
Full diff report 👇
|
description is wrong at the bottom why is this copy pasted here? These changes address critical security issues by ensuring proper handling of msg.value, preventing ETH from getting stuck in factory contracts, and ensuring the registry is correctly queried when setting up modules. This enhances the security and reliability of the Nexus smart contracts. |
🤖 Slither Analysis Report 🔎Slither report
# Slither report
_This comment was automatically generated by the GitHub Actions workflow._
THIS CHECKLIST IS NOT COMPLETE. Use
constable-statesImpact: Optimization
|
🔒 H-03 - Enforce Registry Calls Before Module Setup to Comply with EIP-7484
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/security-h02 #115 +/- ##
=================================================
Coverage 71.17% 71.17%
=================================================
Files 13 13
Lines 680 680
Branches 151 127 -24
=================================================
Hits 484 484
Misses 196 196
Continue to review full report in Codecov by Sentry.
|
H-03. Registry is never called when setting up modules using the
Bootstrap
contractIssue: In the
Bootstrap
contract, the registry is never called as modules are installed before calling_configureRegistry()
, violating the EIP-7484 spec.Fix: Called
_configureRegistry()
before installing modules to ensure the registry is queried as required.Summary of Fixes:
Bootstrap
contract functions to call_configureRegistry()
before installing modules, ensuring compliance with EIP-7484.