fix: add more events

bcnmy · Jul 3, 2023 · 10c8997 · 10c8997
1 parent aed640d
commit 10c8997
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/transaction-allocator/common/interfaces/ITAHelpers.sol b/src/transaction-allocator/common/interfaces/ITAHelpers.sol
@@ -3,6 +3,7 @@
 pragma solidity 0.8.19;
 
 import {RelayerAddress, TokenAddress, RelayerState} from "../TATypes.sol";
+import {FixedPointType} from "src/library/FixedPointArithmetic.sol";
 
 /// @title ITAHelpers
 interface ITAHelpers {
@@ -13,4 +14,5 @@ interface ITAHelpers {
 
     event DelegatorRewardsAdded(RelayerAddress indexed _relayer, TokenAddress indexed _token, uint256 indexed _amount);
     event NewRelayerState(bytes32 indexed relayerStateHash, RelayerState relayerState);
+    event RelayerProtocolSharesBurnt(RelayerAddress indexed relayerAddress, FixedPointType indexed sharesBurnt);
 }
diff --git a/src/transaction-allocator/modules/delegation/TADelegation.sol b/src/transaction-allocator/modules/delegation/TADelegation.sol
@@ -119,6 +119,8 @@ contract TADelegation is TADelegationGetters, TAHelpers, ITADelegation {
         rs.totalUnpaidProtocolRewards = updatedTotalUnpaidProtocolRewards - relayerRewards - delegatorRewards;
         rs.totalProtocolRewardShares = rs.totalProtocolRewardShares - sharesToBurn;
         relayerInfo.rewardShares = relayerInfo.rewardShares - sharesToBurn;
+
+        emit RelayerProtocolSharesBurnt(_relayer, sharesToBurn);
     }
 
     /// @inheritdoc ITADelegation

diff --git a/src/transaction-allocator/modules/transaction-allocation/TATransactionAllocation.sol b/src/transaction-allocator/modules/transaction-allocation/TATransactionAllocation.sol
@@ -403,7 +403,6 @@ contract TATransactionAllocation is ITATransactionAllocation, TAHelpers, TATrans
         uint256 penalty = _calculatePenalty(stake);
 
         // Initialize protocol reward state cache if not already done
-        // TODO: Test this thoroughly
         if (_state.updatedSharePrice == FP_ZERO) {
             _state.updatedUnpaidProtocolRewards = _getLatestTotalUnpaidProtocolRewardsAndUpdateUpdatedTimestamp();
             _state.updatedSharePrice = _protocolRewardRelayerSharePrice(_state.updatedUnpaidProtocolRewards);
@@ -458,9 +457,10 @@ contract TATransactionAllocation is ITATransactionAllocation, TAHelpers, TATrans
             _relayerInfo.rewardShares = _relayerInfo.rewardShares - protocolRewardSharesBurnt;
 
             _state.totalProtocolRewardSharesBurnt = _state.totalProtocolRewardSharesBurnt + protocolRewardSharesBurnt;
+
+            emit RelayerProtocolSharesBurnt(_relayerAddress, protocolRewardSharesBurnt);
         }
 
-        // TODO: Emit shares burnt
         emit RelayerPenalized(_relayerAddress, updatedStake, _penalty);
     }
 
@@ -503,6 +503,8 @@ contract TATransactionAllocation is ITATransactionAllocation, TAHelpers, TATrans
 
             _state.totalProtocolRewardSharesBurnt = _state.totalProtocolRewardSharesBurnt + protocolRewardSharesBurnt;
             _state.totalProtocolRewardsPaid += relayerRewards + delegatorRewards;
+
+            emit RelayerProtocolSharesBurnt(_relayerAddress, protocolRewardSharesBurnt);
         }
 
         // Penalize the relayer