fix/remediations #57
Merged
fix/remediations #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livingrockrises
requested review from
filmakarov,
ankurdubey521,
Aboudjem,
AmanRaj1608 and
tomarsachin2271
| * @dev This contract will return false if called within the constructor of | ||
| * a contract's deployment, as the code is not yet stored on-chain. | ||
| */ | ||
| function isContract(address account) internal view returns (bool) { |
There was a problem hiding this comment.
This should be moved to a utils library
There was a problem hiding this comment.
updated please check
Aboudjem
approved these changes
Nov 29, 2023
…90-kawach-audit-remediations
ankurdubey521
approved these changes
Nov 29, 2023
livingrockrises
merged commit ef9a994
into
chore/SMA-351-rename-to-sponsorship-pm
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
minor gas optimisations
isContract checks
Related Issue: # (issue number)
Change Type
Checklist
Additional Information
Branch Naming