Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/sma 389 check branch update #56

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Chore/sma 389 check branch update #56

merged 3 commits into from
Nov 30, 2023

Conversation

Aboudjem
Copy link
Contributor

Summary

Update rules of ci with new branch naming

Related Issue: #389

Change Type

  • Bug Fix
  • Refactor

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Information

Branch Naming

@Aboudjem Aboudjem self-assigned this Nov 29, 2023
@linear Linear
Copy link

linear bot commented Nov 29, 2023

SMA-389 Update Branch Checking on scw-contracts and biconomy-paymaster

Update Branch Checking on scw-contracts and biconomy-paymaster following the new flow and naming:

  • feat/
  • fix/
  • chore/
  • release/

livingrockrises
livingrockrises approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmanRaj1608 AmanRaj1608 merged commit 8c85686 into develop Nov 30, 2023
3 checks passed
@AmanRaj1608 AmanRaj1608 deleted the chore/SMA-389-check-branch-update branch November 30, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanRaj1608 AmanRaj1608 AmanRaj1608 approved these changes

@livingrockrises livingrockrises livingrockrises approved these changes

@filmakarov filmakarov Awaiting requested review from filmakarov

@ankurdubey521 ankurdubey521 Awaiting requested review from ankurdubey521

@tomarsachin2271 tomarsachin2271 Awaiting requested review from tomarsachin2271

Assignees

@Aboudjem Aboudjem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aboudjem @AmanRaj1608 @livingrockrises