Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:rename verifying singelton paymaster to sponsorship paymaster #55

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

livingrockrises
Copy link
Collaborator

Summary

Only keep Sponsorship Paymaster (v2 version which charges premium)

Related Issue: # (issue number)

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Information

Branch Naming

Copy link

linear bot commented Nov 29, 2023

SMA-351 Replace 'Verifying Paymaster' with 'Sponsorship Paymaster' References

Ensure all references to 'Verifying Paymaster' in our code are updated to 'Sponsorship Paymaster'.

@Aboudjem
Copy link
Contributor

There are still some occurrences here:

File: ./contracts/token/BiconomyTokenPaymaster.sol
File: ./contracts/references/AdvancedVerifyingPaymaster.sol
File: ./contracts/sponsorship/SponsorshipPaymaster.sol

File: ./test/sponsorship-paymaster/biconomy-sponsorship-paymaster-specs.ts
File: ./test/bundler-integration/sponsorship-paymaster/biconomy-sponsorship-paymaster-specs.ts

There are also some instances of "VerifyingSigner" that should be renamed to align with the changes above

@livingrockrises
Copy link
Collaborator Author

There are still some occurrences here:

File: ./contracts/token/BiconomyTokenPaymaster.sol
File: ./contracts/references/AdvancedVerifyingPaymaster.sol
File: ./contracts/sponsorship/SponsorshipPaymaster.sol

File: ./test/sponsorship-paymaster/biconomy-sponsorship-paymaster-specs.ts
File: ./test/bundler-integration/sponsorship-paymaster/biconomy-sponsorship-paymaster-specs.ts

There are also some instances of "VerifyingSigner" that should be renamed to align with the changes above

There is no point of changing in the references.

Also verifyingSigner is a term it should be there as var name. Sponsorship paymaster uses a verifying signer

@livingrockrises livingrockrises merged commit 45be83f into develop Dec 4, 2023
3 checks passed
@livingrockrises livingrockrises deleted the chore/SMA-351-rename-to-sponsorship-pm branch December 4, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants