🐛 fix bug due to this.skip()

bcnmy · Nov 8, 2023 · 754df1b · 754df1b
1 parent f3352f8
commit 754df1b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 22 deletions.
diff --git a/test/bundler-integration/token-paymaster/biconomy-token-paymaster-specs.ts b/test/bundler-integration/token-paymaster/biconomy-token-paymaster-specs.ts
@@ -206,15 +206,13 @@ describe("Biconomy Token Paymaster (with Bundler)", function () {
 
   after(async function () {
     const chainId = (await ethers.provider.getNetwork()).chainId;
-    if (chainId !== BundlerTestEnvironment.BUNDLER_ENVIRONMENT_CHAIN_ID) {
-      this.skip();
+    if (chainId === BundlerTestEnvironment.BUNDLER_ENVIRONMENT_CHAIN_ID) {
+      await Promise.all([
+        environment.revert(environment.defaultSnapshot!),
+        environment.resetBundler(),
+      ]);
     }
-
-    await Promise.all([
-      environment.revert(environment.defaultSnapshot!),
-      environment.resetBundler(),
-    ]);
-  });
+    });
 
   describe("Token Payamster functionality: positive test", () => {
     it("succeed with valid signature and valid erc20 pre approval for allowed ERC20 token: Deployed account", async () => {

diff --git a/test/bundler-integration/token-paymaster/btpm-undeployed-wallet.ts b/test/bundler-integration/token-paymaster/btpm-undeployed-wallet.ts
@@ -201,14 +201,12 @@ describe("Biconomy Token Paymaster (with Bundler)", function () {
 
   after(async function () {
     const chainId = (await ethers.provider.getNetwork()).chainId;
-    if (chainId !== BundlerTestEnvironment.BUNDLER_ENVIRONMENT_CHAIN_ID) {
-      this.skip();
+    if (chainId === BundlerTestEnvironment.BUNDLER_ENVIRONMENT_CHAIN_ID) {  
+      await Promise.all([
+        environment.revert(environment.defaultSnapshot!),
+        environment.resetBundler(),
+      ]);
     }
-
-    await Promise.all([
-      environment.revert(environment.defaultSnapshot!),
-      environment.resetBundler(),
-    ]);
   });
 
   describe("Token Payamster functionality: positive test", () => {

diff --git a/test/bundler-integration/token-paymaster/oracle-aggregator-specs.ts b/test/bundler-integration/token-paymaster/oracle-aggregator-specs.ts
@@ -229,14 +229,12 @@ describe("Biconomy Token Paymaster (With Bundler)", function () {
 
   after(async function () {
     const chainId = (await ethers.provider.getNetwork()).chainId;
-    if (chainId !== BundlerTestEnvironment.BUNDLER_ENVIRONMENT_CHAIN_ID) {
-      this.skip();
+    if (chainId === BundlerTestEnvironment.BUNDLER_ENVIRONMENT_CHAIN_ID) {  
+      await Promise.all([
+        environment.revert(environment.defaultSnapshot!),
+        environment.resetBundler(),
+      ]);
     }
-
-    await Promise.all([
-      environment.revert(environment.defaultSnapshot!),
-      environment.resetBundler(),
-    ]);
   });
 
   describe("Token Paymaster with good and bad oracle aggregator", () => {