Adds option to disable union type de-duplication for performance reasons #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey all, Just want to bump this PR. It's an unobtrusive opt-in feature that we need at Payload CMS to improve performance while using this package. Can I assist with review / merge / publish in any way? |
This was referenced May 15, 2022
|
Superseded by #447 |
|
Amazing, @bcherny. Thank you, and keep up the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain controlled scenarios, a developer can take it upon him/herself to avoid union type duplication in their JSON schema before compiling with
json-schema-to-typescript.In these cases, it would be ideal to skip the performance-intensive manner that this package de-duplicates union types.
This PR adds an opt-in option to skip union type de-duplication.
This option has the potential to dramatically increase performance in some large schemas and addresses a way to circumvent the issue identified in #422.