-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Vietnamese Citizen Identity Card Number #570
base: master
Are you sure you want to change the base?
Conversation
Great work. Thank you for this pull request. I'll try to get to this soon, but might be a little difficult with the holidays coming up, I'll be at the airport in a few days and hopefully I will try to review this while I wait at the terminal |
Happy to hear that ^^. It's just some simple work done in my spare time cuz I really love Bogus. |
Hi @git03-Nguyen; thanks again for the PR. After reviewing this PR at the airport, it appears we are slightly misaligned with some of city names which could potentially throw some exceptions when this code executes. I diffed the following
then compared it to the We should probably get these two lists corrected and synchronized so we don't stumble on an exception with Let me know what you think. |
Hi @bchavez , thank you so much for your review, and I apologize for my negligence. I’ve now pushed two commits:
Please let me know if there’s anything else you'd like me to adjust. I really appreciate your feedback! <3 |
Hello, this PR added extension method to generate Vietnamese 12-digit Citizen Identity Card Number ("Căn cước công dân - CCCD" in local language):
Cccd()
onPerson
object inBogus.Extensions.Vietnam
namespace.README.md
.