Added new Chilean RUT generator #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the System namespace.
…not use the dotFormat as default.
…uding unit tests.
…/acidrod/Bogus into feature/UnitTestingForChileanRUT
|
This PR addresses the Issue #474 |
…y tests are passing locally but failing on appveyor bchavez#474
bchavez
force-pushed
the
master
branch
22 times, most recently
from
1be8d30 to
d0be670
Compare
bchavez
force-pushed
the
master
branch
7 times, most recently
from
0b65acc to
cc799df
Compare
bchavez
requested changes
Jan 14, 2024
Comment on lines
+39
to
+40
| Random rnd = new(); | ||
| int num = rnd.Next(1000000, 99999999); |
There was a problem hiding this comment.
We shouldn't call new Random() in Bogus because it's not deterministic. We'll need to source the rnd from Person.Random to get the randomizer, and then ask for the rnd.Next().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a full Chilean RUT generator for extending the Person and Company classes (Both of them use the Rut ID). The tests are fully validating the generation for random IDs.