Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deseng692: Reverted to previous title logic for video widget #2595

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

jareth-whitney
Copy link
Contributor

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-692

Description of changes:

  • Removed unneeded columns from db (title from widget_video table and associated translation column)
  • Updated all other met_api and met_web logic to accomodate this
  • Title is now pulled from widget table, not widget_video table

User Guide update ticket (if applicable):
N/A

Copy link

sonarcloud bot commented Sep 26, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (e594f0d) to head (12f4f29).

Files with missing lines Patch % Lines
...agement/old-view/widgets/Video/VideoWidgetView.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2595   +/-   ##
=======================================
  Coverage   75.10%   75.10%           
=======================================
  Files         612      612           
  Lines       22254    22247    -7     
  Branches     1870     1869    -1     
=======================================
- Hits        16714    16709    -5     
+ Misses       5267     5265    -2     
  Partials      273      273           
Flag Coverage Δ
metapi 87.13% <100.00%> (+<0.01%) ⬆️
metweb 64.11% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
met-api/src/met_api/models/widget_translation.py 98.00% <ø> (-0.04%) ⬇️
met-api/src/met_api/models/widget_video.py 100.00% <ø> (ø)
met-api/src/met_api/schemas/widget_translation.py 100.00% <ø> (ø)
met-api/src/met_api/schemas/widget_video.py 100.00% <100.00%> (ø)
...src/met_api/services/widget_translation_service.py 76.47% <ø> (+0.88%) ⬆️
...t-api/src/met_api/services/widget_video_service.py 94.28% <ø> (-0.16%) ⬇️
...s/engagement/form/EngagementWidgets/Video/Form.tsx 75.75% <100.00%> (+0.75%) ⬆️
.../src/services/widgetService/VideoService/index.tsx 27.27% <ø> (ø)
...agement/old-view/widgets/Video/VideoWidgetView.tsx 19.04% <0.00%> (ø)

Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for saving us some code and using existing fields where we can!

@jareth-whitney jareth-whitney merged commit d735284 into main Sep 26, 2024
15 checks passed
@jareth-whitney jareth-whitney deleted the feature/deseng692 branch September 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants