[To Main] Task - DESENG-676: Combine custom and summary content #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DESENG-675 Make widget component "reusable" * DESENG-675 Update changelog, contributing, met-web tests * DESENG-675 Merge import statements, add warning style to widget deletion
NatSquared
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 76.03% 76.02% -0.02%
==========================================
Files 609 597 -12
Lines 22105 21652 -453
Branches 1797 1770 -27
==========================================
- Hits 16808 16460 -348
+ Misses 5033 4936 -97
+ Partials 264 256 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Baelx
approved these changes
Sep 3, 2024
| @staticmethod | ||
| def _find_higest_sort_index(engagement_id): | ||
| # find the highest sort order of the engagement content | ||
| sort_index = 0 | ||
| contents = EngagementContentModel.get_contents_by_engagement_id(engagement_id) | ||
| contents = EngagementContentModel.find_by_engagement_id(engagement_id) |
There was a problem hiding this comment.
Thanks for making the names less redundant here :)
| @@ -5,16 +5,16 @@ import { ActionContext } from './ActionContext'; | |||
| import { Skeleton } from '@mui/material'; | |||
| import { getEditorStateFromRaw } from 'components/common/RichTextEditor/utils'; | |||
|
|
|||
| export const EngagementContent = () => { | |||
| const { richContent, isEngagementLoading } = useContext(ActionContext); | |||
| export const EngagementContent = ({ index = 0 }: { index?: number }) => { | |||
There was a problem hiding this comment.
Thanks for making the old view work with this. Hopefully we can ditch this code soon
| @@ -187,7 +192,7 @@ describe('Engagement View page tests', () => { | |||
| mockWidgetsRtkUnwrap.mockReturnValueOnce(Promise.resolve([whoIsListeningWidget])); | |||
| mockContactRtkUnwrap.mockReturnValueOnce(Promise.resolve(mockContact)); | |||
| const { container } = render(<RouterProvider router={router} />); | |||
|
|
|||
| screen.debug(undefined, 10000); | |||
There was a problem hiding this comment.
Does this need to be here still?
|
NatSquared
deleted the
task/DESENG-676-combine-custom-and-summary-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: 🎟️ DESENG-676
Description of changes:
the existing EngagementContent table
User Guide update ticket (if applicable):