-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[To Main] Style hotfix for Chromium-based browsers #2572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Nat! Thanks for doing that hot fix for our demo.
<Box component="main" sx={{ flexGrow: 1, marginTop: { xs: '3.5em', md: '6.5em' } }}> | ||
<Box | ||
component="main" | ||
sx={{ flexGrow: 1, marginTop: { xs: '3.5em', md: '6.5em' }, width: '100%', overflowX: 'auto' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Was that right padding present on the header element? Maybe it was just introduced with a component.
@@ -269,8 +269,6 @@ const TenantSelector = ({ | |||
<TenantButtonContent isOpen={tenantDrawerOpen} /> | |||
</ButtonBase> | |||
<Drawer | |||
disableEnforceFocus | |||
disablePortal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to look these props up, so many cool things you can do with mui.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
=======================================
Coverage 76.03% 76.03%
=======================================
Files 609 609
Lines 22075 22075
Branches 1782 1782
=======================================
Hits 16785 16785
Misses 5026 5026
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Quality Gate passedIssues Measures |
Issue #: N/A
Description of changes: