Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Style hotfix for Chromium-based browsers #2572

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

NatSquared
Copy link
Contributor

Issue #: N/A

Description of changes:

  • Hotfix Fix styling issues with the new admin header
    • Fixed an issue where page widths above 100% were causing the header to become misaligned
    • Fixed a z-index issue with the tenant selector on mobile

Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Copy link
Contributor

@jareth-whitney jareth-whitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Nat! Thanks for doing that hot fix for our demo.

<Box component="main" sx={{ flexGrow: 1, marginTop: { xs: '3.5em', md: '6.5em' } }}>
<Box
component="main"
sx={{ flexGrow: 1, marginTop: { xs: '3.5em', md: '6.5em' }, width: '100%', overflowX: 'auto' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Was that right padding present on the header element? Maybe it was just introduced with a component.

@@ -269,8 +269,6 @@ const TenantSelector = ({
<TenantButtonContent isOpen={tenantDrawerOpen} />
</ButtonBase>
<Drawer
disableEnforceFocus
disablePortal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to look these props up, so many cool things you can do with mui.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (ec3c7be) to head (2435d29).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2572   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         609      609           
  Lines       22075    22075           
  Branches     1782     1782           
=======================================
  Hits        16785    16785           
  Misses       5026     5026           
  Partials      264      264           
Flag Coverage Δ
metweb 65.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eb/src/components/layout/Header/InternalHeader.tsx 87.12% <ø> (ø)

Copy link

sonarcloud bot commented Aug 6, 2024

@NatSquared NatSquared merged commit 75aed45 into main Aug 6, 2024
8 checks passed
@NatSquared NatSquared deleted the hotfix/chromium-styling-issues branch August 6, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants