Feature/deseng662: Implemented new footer #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jareth-whitney
commented
Jul 31, 2024
jareth-whitney
commented
- Feature New footer (public and admin) 🎟️ DESENG-662
- Implemented new footer design for desktop and mobile viewports.
- Addressed some issues with z-index between footer and side nav.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
+ Coverage 76.04% 76.07% +0.03%
==========================================
Files 609 609
Lines 22075 22036 -39
Branches 1782 1782
==========================================
- Hits 16786 16763 -23
+ Misses 5025 5009 -16
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Baelx
approved these changes
Jul 31, 2024
|
|
||
| return ( | ||
| <Grid container justifyContent="center" alignItems="center" spacing={0} mt="2em"> | ||
| <Grid container component="footer" spacing={0} mt="2em" aria-label="footer"> |
There was a problem hiding this comment.
Thanks for being explicit about the HTML element!
| > | ||
| <Grid item xs={12}> | ||
| <Stack spacing={3}> | ||
| <MetLabel>{translate('footer.moreInfo')}</MetLabel> |
There was a problem hiding this comment.
I'd recommend using a span or even a heading tag here instead. Labels are usually just used with inputs and form fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.