Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deseng657 #2561

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Feature/deseng657 #2561

merged 6 commits into from
Jul 22, 2024

Conversation

jareth-whitney
Copy link
Contributor

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-657

  • Small change to conditional in language selector due to an error on the test server. The conditional for checking if a language is right_to_left needs to account for the value not existing in the language entry.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (ce13757) to head (e80224c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2561   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         609      609           
  Lines       21960    21960           
  Branches     1711     1711           
=======================================
  Hits        16682    16682           
  Misses       5015     5015           
  Partials      263      263           
Flag Coverage Δ
metweb 64.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@NatSquared NatSquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - would recommend using CSS instead of reversing text

met-web/src/components/engagement/new/create/index.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 22, 2024

@jareth-whitney jareth-whitney merged commit e5155b2 into main Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants