Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Removing web components #2530

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[To Main] Removing web components #2530

merged 2 commits into from
Jun 3, 2024

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-616

Description of changes:

  • Removed web components and all code that references it

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review May 30, 2024 16:20
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (6d13309) to head (64627be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2530   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         604      604           
  Lines       21784    21784           
  Branches     1666     1663    -3     
=======================================
  Hits        16549    16549           
  Misses       4972     4972           
  Partials      263      263           
Flag Coverage Δ
metweb 64.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-web/src/config.ts 96.77% <100.00%> (ø)

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@NatSquared NatSquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for cleaning this up

@NatSquared NatSquared merged commit d6af0d8 into main Jun 3, 2024
8 checks passed
@NatSquared NatSquared deleted the feature/deseng-616 branch June 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants