Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make widget title editable #1961

Merged
merged 7 commits into from
Aug 4, 2023
Merged

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Create editable WidgetTitle component
  • Use WidgetTitle for all widget drawers
  • use widget.title to display the widgets titles
  • Add default titles

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Aug 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #1961 (b533e6a) into main (bb6990d) will decrease coverage by 0.19%.
Report is 8 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
- Coverage   69.75%   69.56%   -0.19%     
==========================================
  Files         440      441       +1     
  Lines       13362    13495     +133     
  Branches      989     1006      +17     
==========================================
+ Hits         9320     9388      +68     
- Misses       3864     3923      +59     
- Partials      178      184       +6     
Flag Coverage Δ
metapi 77.89% <33.33%> (-0.27%) ⬇️
metweb 62.43% <57.29%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
met-web/src/apiManager/endpoints/index.ts 100.00% <ø> (ø)
...gement/form/EngagementWidgets/WidgetCardSwitch.tsx 20.45% <ø> (ø)
...ent/form/EngagementWidgets/WidgetDrawerContext.tsx 66.66% <0.00%> (-2.73%) ⬇️
...ponents/engagement/view/widgets/DocumentWidget.tsx 31.03% <ø> (ø)
...ts/engagement/view/widgets/Events/EventsWidget.tsx 35.29% <ø> (ø)
...mponents/engagement/view/widgets/Map/MapWidget.tsx 37.14% <ø> (ø)
...esWidget/PhasesWidgetMobile/PhasesWidgetMobile.tsx 96.87% <ø> (ø)
...nts/engagement/view/widgets/PhasesWidget/index.tsx 44.44% <ø> (ø)
.../engagement/view/widgets/Video/VideoWidgetView.tsx 28.57% <ø> (ø)
...s/engagement/view/widgets/WhoIsListeningWidget.tsx 88.23% <ø> (ø)
... and 23 more

... and 8 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadmsaadaot jadmsaadaot marked this pull request as ready for review August 3, 2023 19:59
@jadmsaadaot jadmsaadaot merged commit 545ae41 into bcgov:main Aug 4, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Make widget title updatable

* Add widget title to all components

* Show the widget.title in the engagement view

* remove unsued imports

* fix lint issues

* fix flake8 issue

* Fix failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants