Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for email verification template #1960

Merged
merged 16 commits into from
Aug 3, 2023
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Description of changes:

  • updated the email verification template
  • added new arguments needed for the updated template

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #1960 (85ed7ce) into main (121114c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
+ Coverage   69.75%   69.76%   +0.01%     
==========================================
  Files         440      440              
  Lines       13362    13370       +8     
  Branches      989      989              
==========================================
+ Hits         9320     9328       +8     
  Misses       3864     3864              
  Partials      178      178              
Flag Coverage Δ
metapi 78.18% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
met-api/src/met_api/config.py 99.25% <100.00%> (+0.01%) ⬆️
...src/met_api/services/email_verification_service.py 77.93% <100.00%> (+0.95%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment on lines +100 to +101
ENGAGEMENT_PATH = os.getenv('ENGAGEMENT_PATH', '/engagements/{engagement_id}/view')
ENGAGEMENT_PATH_SLUG = os.getenv('ENGAGEMENT_PATH_SLUG', '/{slug}')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add a comment saying these are the front end urls

@VineetBala-AOT VineetBala-AOT merged commit dee225d into bcgov:main Aug 3, 2023
12 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* updates on engagement publish

* update email template

* adding action drop down

* updated changes for User Management

* access user details page for users without a role

* updating variable name

* updating the schema

* updating as per review comments

* updating schema

* adding changes for clone and delete

* fixing linting

* update

* fix for report setting on analytics

* fixing lint

* Changes for email verification template

* fixing linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants