Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default translation file #1938

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Add default text file
  • Handle if text file wasn't found
  • Handle when tenant not loaded

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Aug 1, 2023
@jadmsaadaot jadmsaadaot marked this pull request as ready for review August 1, 2023 17:35
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #1938 (3482c42) into main (1447dfd) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
- Coverage   69.74%   69.73%   -0.02%     
==========================================
  Files         440      440              
  Lines       13354    13356       +2     
  Branches      985      985              
==========================================
  Hits         9314     9314              
- Misses       3862     3864       +2     
  Partials      178      178              
Flag Coverage Δ
metweb 62.50% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
met-web/src/reduxSlices/tenantSlice.ts 41.66% <0.00%> (-3.79%) ⬇️

... and 1 file with indirect coverage changes

@jadmsaadaot jadmsaadaot merged commit a9984bf into bcgov:main Aug 1, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Add default translation file

* remove explicit any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants