Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change close preview button to edit #1934

Merged
merged 16 commits into from
Aug 1, 2023
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Description of changes:

  • Changed the close preview button to edit on engagement and survey preview
  • Added check to disable button for users not having edit role

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #1934 (67f6f8f) into main (9568af5) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1934   +/-   ##
=======================================
  Coverage   69.74%   69.74%           
=======================================
  Files         440      440           
  Lines       13355    13355           
  Branches      985      985           
=======================================
  Hits         9314     9314           
  Misses       3863     3863           
  Partials      178      178           
Flag Coverage Δ
metweb 62.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...b/src/components/engagement/view/PreviewBanner.tsx 74.00% <0.00%> (ø)

@saravanpa-aot saravanpa-aot merged commit 16c08d6 into bcgov:main Aug 1, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants