Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engagement settings UX/UI fixes #1908

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Update text
  • Add an update restriction based on engagement status

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Jul 27, 2023
@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 27, 2023 19:33
@codecov-commenter
Copy link

Codecov Report

Merging #1908 (c0731fc) into main (a7bc1c8) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   70.58%   70.53%   -0.06%     
==========================================
  Files         423      423              
  Lines       12761    12793      +32     
  Branches      961      962       +1     
==========================================
+ Hits         9007     9023      +16     
- Misses       3587     3603      +16     
  Partials      167      167              
Flag Coverage Δ
metapi 78.42% <40.00%> (-0.18%) ⬇️
metweb 63.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ement/form/EngagementFormTabs/Links/PublicUrls.tsx 49.27% <ø> (ø)
...rc/met_api/services/engagement_metadata_service.py 46.34% <26.66%> (-2.05%) ⬇️
...rc/met_api/services/engagement_settings_service.py 63.63% <40.00%> (-6.96%) ⬇️
met-api/src/met_api/services/engagement_service.py 68.09% <60.00%> (-1.33%) ⬇️
...agementFormTabs/Settings/EngagementInformation.tsx 89.47% <100.00%> (+1.23%) ⬆️
...entFormTabs/Settings/EngagementSettingsContext.tsx 50.00% <100.00%> (+2.50%) ⬆️
...EngagementFormTabs/Settings/InternalEngagement.tsx 91.66% <100.00%> (+0.75%) ⬆️
...nt/form/EngagementFormTabs/Settings/SendReport.tsx 78.26% <100.00%> (+0.98%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadmsaadaot jadmsaadaot merged commit 1d4c498 into bcgov:main Jul 27, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Add restriction by status for update

* fix lint issues

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants