Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor engagement settings to have one consolidated save button #1889

Merged
merged 17 commits into from
Jul 27, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Create context for settings
  • Move urls to separate tab
  • remove separate save buttons in settings tab
  • Add one save button that calls save methods of all

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Jul 25, 2023
@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 25, 2023 18:28
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #1889 (f395312) into main (eab4d43) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 72.63%.

@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
+ Coverage   70.53%   70.61%   +0.08%     
==========================================
  Files         420      423       +3     
  Lines       12715    12750      +35     
  Branches      951      954       +3     
==========================================
+ Hits         8969     9004      +35     
+ Misses       3580     3579       -1     
- Partials      166      167       +1     
Flag Coverage Δ
metapi 78.59% <100.00%> (+0.25%) ⬆️
metweb 63.80% <69.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ts/engagement/form/EngagementFormTabs/constants.ts 100.00% <ø> (ø)
...EngagementWidgets/Map/ShapeFileUpload/Uploader.tsx 53.84% <ø> (ø)
...entFormTabs/Settings/EngagementSettingsContext.tsx 47.50% <47.50%> (ø)
.../form/EngagementFormTabs/EngagementTabsContext.tsx 68.93% <50.00%> (+1.64%) ⬆️
...b/src/components/engagement/form/ActionContext.tsx 53.41% <66.66%> (-2.56%) ⬇️
...EngagementFormTabs/Settings/InternalEngagement.tsx 90.90% <80.00%> (-0.76%) ⬇️
...t-api/src/met_api/resources/engagement_settings.py 56.25% <100.00%> (+6.25%) ⬆️
met-api/src/met_api/services/engagement_service.py 69.42% <100.00%> (+0.39%) ⬆️
...rc/met_api/services/engagement_settings_service.py 70.58% <100.00%> (+23.92%) ⬆️
...ts/engagement/form/EngagementFormTabs/FormTabs.tsx 100.00% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

@saravanpa-aot saravanpa-aot merged commit 4151747 into bcgov:main Jul 27, 2023
16 checks passed
@jadmsaadaot jadmsaadaot changed the title Refactor engagement settings to have on consolidated save button Refactor engagement settings to have one consolidated save button Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants