Subscribe Widget - Email list form tab #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djnunez-aot
requested review from
jadmsaadaot,
saravanpa-aot and
VineetBala-AOT
as code owners
djnunez-aot
changed the title
jadmsaadaot
reviewed
Jul 24, 2023
| resolver: yupResolver(schema), | ||
| }); | ||
|
|
||
| const getTextFromDraftJsContentState = (contentJSON: string): string => { |
There was a problem hiding this comment.
Theres's a utils file in the rich text editor folder, could you check if this exists there already and if not to add it there
There was a problem hiding this comment.
it does not but I added it there as you suggested
jadmsaadaot
reviewed
Jul 24, 2023
| .object({ | ||
| description: yup.string().max(500, 'Description cannot exceed 500 characters'), | ||
| cta_type: yup.string(), | ||
| cta_text: yup.string().max(25, 'Description cannot exceed 25 characters'), |
There was a problem hiding this comment.
can you choose a more descriptive name than cta, also the error message still has Description
djnunez-aot
force-pushed
the
email-list-tab
branch
from
df328e7
to
d0edb26
Compare
Codecov Report
@@ Coverage Diff @@
## main #1879 +/- ##
==========================================
- Coverage 70.38% 69.73% -0.66%
==========================================
Files 426 439 +13
Lines 12874 13354 +480
Branches 974 989 +15
==========================================
+ Hits 9061 9312 +251
- Misses 3644 3864 +220
- Partials 169 178 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
djnunez-aot
force-pushed
the
email-list-tab
branch
from
575748e
to
0b1ee8f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jadmsaadaot
approved these changes
Jul 31, 2023
NatSquared
pushed a commit
that referenced
this pull request
Oct 19, 2023
* email list & form sign up tabs * add rich text editor to both drawers * push changes * add subscribe widget path * add print statements for debugging * update routes * update column type cleanup pr * cleanup pr * remove unused imports * py lint * lint and add unit test * update revisions * update test file * pylint * Update factory_scenarios.py * add subscription import * pylint * fix head colisions * update tests * update test * add .strip function for json * update * update widget test * add more logs * lint * isort fix * application out of context error * add widget_id to filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add form for Email list
-Add rich editor to context
-update subscribe context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).