Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button styling update #1871

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

djnunez-aot
Copy link
Collaborator

-Remove form io button radius:0 as it prevents us from styling their components

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djnunez-aot djnunez-aot enabled auto-merge (squash) July 24, 2023 16:25
@jadmsaadaot
Copy link
Collaborator

"-Remove form io button radius:0 as it prevents us from styling their components"

their? which components?

@djnunez-aot
Copy link
Collaborator Author

@jadmsaadaot The ones that show up when we display a survey. In this case it's the next and previous button. This pr is made because there's some small hover artifacts since form io scss overrides some styles for the buttons.

@djnunez-aot djnunez-aot merged commit fd70b29 into bcgov:main Jul 25, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants