Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview changes when mock status changes #1858

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Improved preview status button functionality
  • moved rich text editor to common
  • Refactored survey block

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #1858 (797298a) into main (915fc72) will decrease coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
- Coverage   70.74%   70.74%   -0.01%     
==========================================
  Files         410      411       +1     
  Lines       12463    12471       +8     
  Branches      936      945       +9     
==========================================
+ Hits         8817     8822       +5     
- Misses       3486     3488       +2     
- Partials      160      161       +1     
Flag Coverage Δ
metweb 63.76% <94.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/src/components/engagement/view/PreviewBanner.tsx 74.00% <ø> (ø)
met-web/src/utils/index.ts 25.92% <ø> (-13.47%) ⬇️
...web/src/components/engagement/view/SurveyBlock.tsx 89.28% <72.72%> (-10.72%) ⬇️
...web/src/components/common/RichTextEditor/index.tsx 78.37% <100.00%> (ø)
...-web/src/components/common/RichTextEditor/utils.ts 100.00% <100.00%> (ø)
...agement/form/EngagementFormTabs/EngagementForm.tsx 77.08% <100.00%> (ø)
...mentFormTabs/SurveyBlock/SurveyClosedTextInput.tsx 50.00% <100.00%> (ø)
...gementFormTabs/SurveyBlock/SurveyOpenTextInput.tsx 50.00% <100.00%> (ø)
...ntFormTabs/SurveyBlock/SurveyUpcomingTextInput.tsx 90.00% <100.00%> (ø)
met-web/src/components/engagement/status/index.tsx 93.10% <100.00%> (+2.19%) ⬆️
... and 3 more

... and 2 files with indirect coverage changes

@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 19, 2023 01:44
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadmsaadaot jadmsaadaot merged commit aed6a1f into bcgov:main Jul 19, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Fix preview changes when mock status changes

* remove redundant return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants