Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tweaks for the comment listing page #1854

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Adding padding between the search and header.
  • The size of "Reset All Filters" should match the size of other buttons, and remove "Filter by" for all the dates fields in the advanced search and change Filter from "Reviewed Date" to "Review Date”.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Jul 18, 2023
@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 18, 2023 19:02
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #1854 (6a4f91b) into main (b8916cf) will not change coverage.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files         410      410           
  Lines       12463    12463           
  Branches      936      936           
=======================================
  Hits         8817     8817           
  Misses       3486     3486           
  Partials      160      160           
Flag Coverage Δ
metweb 63.76% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/comments/admin/reviewListing/AdvancedSearch.tsx 63.15% <ø> (ø)
...nents/comments/admin/reviewListing/Submissions.tsx 87.50% <40.00%> (ø)

@jadmsaadaot jadmsaadaot merged commit 620ecf9 into bcgov:main Jul 19, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants