Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement document uploading #1840

Merged
merged 20 commits into from
Jul 17, 2023
Merged

Conversation

jadmsaadaot
Copy link
Collaborator

Description of changes:

  • Make common file upload
  • move existing not so common file upload to map widget as shapefile upload
  • add upload doc drawer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Jul 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #1840 (469d44f) into main (10044b8) will decrease coverage by 0.12%.
The diff coverage is 63.84%.

@@            Coverage Diff             @@
##             main    #1840      +/-   ##
==========================================
- Coverage   70.86%   70.75%   -0.12%     
==========================================
  Files         406      410       +4     
  Lines       12353    12462     +109     
  Branches      925      936      +11     
==========================================
+ Hits         8754     8817      +63     
- Misses       3442     3485      +43     
- Partials      157      160       +3     
Flag Coverage Δ
metapi 78.84% <100.00%> (+0.01%) ⬆️
metweb 63.77% <61.67%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
met-web/src/components/common/FileUpload/index.tsx 50.00% <ø> (ø)
...orm/EngagementWidgets/Documents/DocumentFolder.tsx 66.12% <ø> (ø)
met-web/src/models/document.ts 100.00% <ø> (ø)
...c/services/widgetService/DocumentService/index.tsx 19.04% <ø> (ø)
...b/src/components/engagement/form/ActionContext.tsx 55.97% <50.00%> (ø)
...agementWidgets/WhoIsListening/AddContactDrawer.tsx 54.21% <50.00%> (ø)
...EngagementWidgets/Map/ShapeFileUpload/Uploader.tsx 53.84% <53.84%> (ø)
...m/EngagementWidgets/Documents/UploadFileDrawer.tsx 56.25% <56.25%> (ø)
...m/EngagementWidgets/Documents/DocumentsContext.tsx 70.21% <57.14%> (-2.52%) ⬇️
met-web/src/services/objectStorageService/index.ts 36.84% <57.14%> (ø)
... and 13 more

@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 14, 2023 15:49
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadmsaadaot jadmsaadaot merged commit 4ceabbf into bcgov:main Jul 17, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Refactor common file upload

* change naming to addFileDrawer

* Add upload document drawer and functionality

* Add common file upload

* Fix spacing folder paper

* fix code smells

* cleanup shapefile upload

* change naming to reflect which file uploader is used

* change object service methods to use the name object

* remove duplicate file import

* Add is uploaded column to documents widget table

* tweak update document

* remove unused import

* revert icon choices

* update package lock

* update package lock

* add unit test for upload drawer

* update tests

* remove failing test for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants