-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add survey settings unit tests #1827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadmsaadaot
requested review from
djnunez-aot,
saravanpa-aot and
VineetBala-AOT
as code owners
July 11, 2023 20:58
Codecov Report
@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
+ Coverage 71.27% 71.51% +0.23%
==========================================
Files 389 396 +7
Lines 11848 12021 +173
Branches 893 910 +17
==========================================
+ Hits 8445 8597 +152
- Misses 3257 3277 +20
- Partials 146 147 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
saravanpa-aot
approved these changes
Jul 12, 2023
NatSquared
pushed a commit
that referenced
this pull request
Oct 19, 2023
* implement client side pagination * add fetch report settings * Add checkbox and refine components * call patch update with the updated settings * handle navigation on save * validate survey during update * fix lint and unit test * Add service test * replace double quote with single * Complete dashboard url copy functionality * load engagement slug * remove generate dashboard button setting from report settings * remove only from unit test * update docstring and function names * Add unit tests for survey report settings page * Add edit settings in dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).