Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add survey settings unit tests #1827

Merged
merged 19 commits into from
Jul 12, 2023
Merged

Conversation

jadmsaadaot
Copy link
Collaborator

@jadmsaadaot jadmsaadaot commented Jul 11, 2023

Description of changes:

  • Add survey settings unit tests
  • Add edit survey settings to action drop down in survey listing

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@jadmsaadaot jadmsaadaot self-assigned this Jul 11, 2023
@jadmsaadaot jadmsaadaot marked this pull request as ready for review July 11, 2023 20:58
@codecov-commenter
Copy link

Codecov Report

Merging #1827 (8028622) into main (978208c) will increase coverage by 0.23%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
+ Coverage   71.27%   71.51%   +0.23%     
==========================================
  Files         389      396       +7     
  Lines       11848    12021     +173     
  Branches      893      910      +17     
==========================================
+ Hits         8445     8597     +152     
- Misses       3257     3277      +20     
- Partials      146      147       +1     
Flag Coverage Δ
metweb 64.67% <33.33%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/survey/listing/ActionsDropDown.tsx 68.51% <0.00%> (-2.64%) ⬇️
met-web/src/components/survey/report/SearchBar.tsx 100.00% <ø> (ø)
...web/src/components/survey/report/SettingsTable.tsx 100.00% <ø> (ø)
...-web/src/components/survey/report/SettingsForm.tsx 88.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jadmsaadaot jadmsaadaot merged commit 0f9a977 into bcgov:main Jul 12, 2023
9 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* implement client side pagination

* add fetch report settings

* Add checkbox and refine components

* call patch update with the updated settings

* handle navigation on save

* validate survey during update

* fix lint and unit test

* Add service test

* replace double quote with single

* Complete dashboard url copy functionality

* load engagement slug

* remove generate dashboard button setting from report settings

* remove only from unit test

* update docstring and function names

* Add unit tests for survey report settings page

* Add edit settings in dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants