Add survey report settings page #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1810 +/- ##
==========================================
- Coverage 70.85% 70.82% -0.03%
==========================================
Files 389 389
Lines 11846 11840 -6
Branches 893 893
==========================================
- Hits 8393 8386 -7
- Misses 3300 3301 +1
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jadmsaadaot
requested review from
djnunez-aot,
saravanpa-aot and
VineetBala-AOT
as code owners
|
Front end unit tests will follow this PR |
VineetBala-AOT
approved these changes
Jul 10, 2023
saravanpa-aot
approved these changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
NatSquared
pushed a commit
that referenced
this pull request
Oct 19, 2023
* implement client side pagination * add fetch report settings * Add checkbox and refine components * call patch update with the updated settings * handle navigation on save * validate survey during update * fix lint and unit test * Add service test * replace double quote with single * Complete dashboard url copy functionality * load engagement slug * remove generate dashboard button setting from report settings * remove only from unit test * update docstring and function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).